Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43283
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.235.152.149 cause and error)
Message-ID: <033E05F2D7264057AEE4FCFFD7E827AE@pc1>
To: "PHP Internals List" <internals@lists.php.net>, "shire" <shire@tekrat.com>,
        "Lukas Kahwe Smith" <mls@pooteeweet.org>
References: <EB82BC56-A5EE-4526-861A-8759BBEBEF34@pooteeweet.org> <49B57F4F.9080901@tekrat.com>
Date: Mon, 9 Mar 2009 18:30:09 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 5.3 items
From: php_lists@realplain.com ("Matt Wilmas")

Hi Brian,

----- Original Message -----
From: "shire"
Sent: Monday, March 09, 2009

>
> Hey Lukas,
>
> Just a heads up that I should have a fix for this soonish, just running 
> some more tests to make sure everything works as expected (I assume nobody 
> else has started work on this):
>
> 9.  tokenizer misses last single-line comment 
> (http://bugs.php.net/bug.php?id=46817)

I was going to take care of that one, as I mentioned in a previous message, 
though it's been awhile since I've been delayed much longer with stuff here. 
:-(  (Nothing set up for building PHP on this system yet; hope to in the 
next several hours finally, and do some things!)

As far as I know there's still the other comment-related issue where no 
Warning is giving about "Unterminated comment ..." for unclosed /* ...  It's 
all of course related to the fundamental re2c issue, for now, where when the 
scanned input ends while a variable length part of a rule is being matched, 
it just aborts ("return 0;") in YYFILL().

And that applies to the case Lukas gave in the bug report: WHITESPACE 
pattern is variable length.

The comment issue just happens to be a more obvious thing that was noticed, 
and it doesn't affect actual correct code that ends with a fixed-length ";" 
or "?>"  Some other bits that won't be returned if at the end of a file are 
T_LNUMBER, T_DNUMBER, T_STRING, T_VARIABLE, "The last part in unclosed 
double-quotes or backticks, 'An unclosed single quoted string, and so on, 
likely resulting in a different parse error than previous versions.

T_INLINE_HTML isn't affected by this because it's matched with a manual 
scan, rather than an re2c pattern.  The manual scan may well have been used 
to work around re2c...? :-)


- Matt