Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43282
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain macvicar.net from 193.227.246.108 cause and error)
Cc: Lukas Kahwe Smith <mls@pooteeweet.org>,
 PHP Internals List <internals@lists.php.net>
Message-ID: <AD5C7DA2-F5ED-42F2-B178-E38ACE033233@macvicar.net>
To: shire <shire@tekrat.com>
In-Reply-To: <49B57F4F.9080901@tekrat.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Mon, 9 Mar 2009 22:45:14 +0000
References: <EB82BC56-A5EE-4526-861A-8759BBEBEF34@pooteeweet.org> <49B57F4F.9080901@tekrat.com>
X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has
	identified this incoming email as possible spam.  The original message
	has been attached to this so you can view it (if it isn't spam) or label
	similar future email.  If you have any questions, see
	the administrator of that system for details.
	Content preview:  Hey Brian, On 9 Mar 2009, at 20:42, shire wrote: > > Hey Lukas,
	> > Just a heads up that I should have a fix for this soonish, just > running
	some more tests to make sure everything works as expected (I > assume nobody
	else has started work on this): > > 9. tokenizer misses last single-line
	comment (http://bugs.php.net/bug.php?id=46817 > ) > > What's the details on
	this one? > > 20. memory leak in the scanner when a new state stack is created
	[...] 
	Content analysis details:   (-4.1 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	0.3 AWL                    AWL: From: address is in the auto white-list
Subject: Re: [PHP-DEV] 5.3 items
From: scott@macvicar.net (Scott MacVicar)

Hey Brian,

On 9 Mar 2009, at 20:42, shire wrote:

>
> Hey Lukas,
>
> Just a heads up that I should have a fix for this soonish, just  
> running some more tests to make sure everything works as expected (I  
> assume nobody else has started work on this):
>
> 9.  tokenizer misses last single-line comment (http://bugs.php.net/bug.php?id=46817 
> )
>
> What's the details on this one?
>
> 20. memory leak in the scanner when a new state stack is created

When a file is included and a new state structure is created for the  
scanner its pushed on to a stack for freeing later on, most of the  
time this happens as soon as the scanner has parsed the included file  
but not quite for the tokenizer extension though.

At the moment the destructor for the stack is comparing pointers,  
which are unfortunately different because when you push something with  
zend_stack it does a copy.

I have a fix which just adds an id to the state structure, but this  
requires a little bit more memory.

I think the cleaner fix is to sort the tokenizer extension, just need  
some more time.

Scott