Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43270
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain openmv.com from 64.15.152.204 cause and error)
To: "'Andi Gutmans'" <andi@zend.com>
Cc: "'PHP Developers Mailing List'" <internals@lists.php.net>
References: <002a01c99b56$97b7fd00$c727f700$@com> <698DE66518E7CA45812BD18E807866CE029F4805@us-ex1.zend.net>
In-Reply-To: <698DE66518E7CA45812BD18E807866CE029F4805@us-ex1.zend.net>
Date: Fri, 6 Mar 2009 14:39:59 -0500
Message-ID: <000601c99e93$56c67e80$04537b80$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Thread-Index: AcmbVpXRvcgBz3lWRwWZQb1SjgaG2wAXfqOAALNfJnA=
Content-Language: en-ca
Subject: RE: [PHP-DEV] Stream chunk size
From: jbondc@openmv.com ("Jonathan Bond-Caron")

On Mon Mar 2 11:10 PM, Andi Gutmans wrote:
> I don't see a fundamental issue why it could not be arbitrary.
> The only challenge which may be an issue is that this code clearly 
> allocates the buffer on the stack for what are probably performance 
> reasons. If you allow arbitrary chunk size and use alloca()
> (do_alloca()) for stack allocation you might kill the stack.
> 
> I suggest you do some performance tests and if you need to keep it on 
> the stack then create some arbitrary limit like 8K and use stack below 
> that and use heap above that (code will be uglier).
> 

Thanks for the tips, it's on a todo list