Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43223 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36068 invoked from network); 2 Mar 2009 16:21:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Mar 2009 16:21:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=rquadling@googlemail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.218.180 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 209.85.218.180 mail-bw0-f180.google.com Received: from [209.85.218.180] ([209.85.218.180:52301] helo=mail-bw0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3B/1D-00495-0970CA94 for ; Mon, 02 Mar 2009 11:21:39 -0500 Received: by bwz28 with SMTP id 28so2094683bwz.23 for ; Mon, 02 Mar 2009 08:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:reply-to:date:message-id :subject:from:to:content-type; bh=bV7jXjmJTRrbdrcM494kXmDs7/BIrIJZ9DPX4CwcZCM=; b=BaMWjRE7YBGf4Oa+cYKvWegHWDhjRiLYCJ2MyrL4Aww8XdmWl+cX7cVTGdDvoCQGXs MpQFtsWuceBX4o0PpRdFDvBBYUFH3oeW5IkH77QbHcqWupsozaTyT+wVnSSxmWIHVsUe bMSzfIiWzK+rbOytj2kD6Ilw4pwMJLmMGhxNM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:date:message-id:subject:from:to:content-type; b=ELi6X9sYaBLAgk7Ju1mI3Twmvi/DGJsWgN0WDq6fXHINR9HK9RnhNPfsPA18Oj5I1T h7XQ3j/B6xQKz9l/wvDh8ZhkyGQ7BXAJ64w9flpIB9IpbjMn3X18QKIzNnWmkfFWOtUM CI8BEM9vuQGIYpIil3whdl3IHFp7i+BQ+94Nk= MIME-Version: 1.0 Received: by 10.223.107.68 with SMTP id a4mr6065653fap.104.1236010893269; Mon, 02 Mar 2009 08:21:33 -0800 (PST) Reply-To: RQuadling@googlemail.com Date: Mon, 2 Mar 2009 16:21:33 +0000 Message-ID: <10845a340903020821v718bc762g243864f7e098ee1c@mail.gmail.com> To: PHP Internals List Content-Type: multipart/mixed; boundary=001636c5a4403b5b77046425362c Subject: Patch and test cases too for From: rquadling@googlemail.com (Richard Quadling) --001636c5a4403b5b77046425362c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi. Regarding http://bugs.php.net/bug.php?id=3D47493, I've supplied a patch to the unit tests too. Any chance this could get committed to 5.2+ Index: tests/002.phpt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /repository/php-src/ext/json/tests/002.phpt,v retrieving revision 1.3 diff -u -r1.3 002.phpt --- tests/002.phpt 27 May 2008 18:16:03 -0000 1.3 +++ tests/002.phpt 2 Mar 2009 16:16:13 -0000 @@ -1,4 +1,4 @@ ---TEST-- +=EF=BB=BF--TEST-- json_encode() tests --SKIPIF-- @@ -8,8 +8,14 @@ var_dump(json_encode("")); var_dump(json_encode(NULL)); var_dump(json_encode(TRUE)); + var_dump(json_encode(array(""=3D>""))); var_dump(json_encode(array(array(1)))); +var_dump(json_encode(array()); + +var_dump(json_encode(array(""=3D>"")), PHP_JSON_FORCE_HASH); +var_dump(json_encode(array(array(1))),PHP_JSON_FORCE_HASH); +var_dump(json_encode(array(),PHP_JSON_FORCE_HASH); var_dump(json_encode(1)); var_dump(json_encode("=D1=80=D1=83=D1=81=D1=81=D0=B8=D1=88")); @@ -23,6 +29,10 @@ string(4) "true" string(7) "{"":""}" string(5) "[[1]]" +string(2) "[]" +string(7) "{"":""}" +string(15) "{"0":{"0":"1"}}" +string(2) "{}" string(1) "1" string(38) ""\u0440\u0443\u0441\u0441\u0438\u0448"" Done --=20 ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=3DZEND002498&r=3D213474= 731 "Standing on the shoulders of some very clever giants!" --001636c5a4403b5b77046425362c--