Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43167 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97285 invoked from network); 24 Feb 2009 09:06:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Feb 2009 09:06:38 -0000 Authentication-Results: pb1.pair.com smtp.mail=paul.preece@boxuk.com; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=Paul.Preece@boxuk.com; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain boxuk.com does not designate 212.2.3.157 as permitted sender) X-PHP-List-Original-Sender: paul.preece@boxuk.com X-Host-Fingerprint: 212.2.3.157 service32.mimecast.com Linux 2.4/2.6 Received: from [212.2.3.157] ([212.2.3.157:54124] helo=service32.mimecast.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F8/8A-29217-C98B3A94 for ; Tue, 24 Feb 2009 04:06:38 -0500 Received: from boxuk.com (82-69-194-142.dsl.in-addr.zen.co.uk [82.69.194.142]) by service32.mimecast.com; Tue, 24 Feb 2009 09:06:31 +0000 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Date: Tue, 24 Feb 2009 09:09:51 -0000 Message-ID: In-Reply-To: <49A3A3C2.6090401@thewritingpot.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PHP-DEV] Don't compress empty output with zlib Thread-Index: AcmWWPQCKqPAj2RyTZiIeBFJuqyarAABq1qA References: <49A3A3C2.6090401@thewritingpot.com> To: "Edward Z. Yang" , Cc: , , , X-MC-Unique: 109022409063101102 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: RE: [PHP-DEV] Don't compress empty output with zlib From: Paul.Preece@boxuk.com ("Paul Preece") *bump* -----Original Message----- From: news [mailto:news@ger.gmane.org] On Behalf Of Edward Z. Yang Sent: 24 February 2009 7:38 am To: internals@lists.php.net Cc: rasmus@lerdorf.on.ca; sr@linux.de; zeev@zend.com; nicoletti@nns.ch Subject: Re: [PHP-DEV] Don't compress empty output with zlib CC'ed authors of zlib.c Could this patch be applied to PHP_5_2 and further? Index: ext/zlib/zlib.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /repository/php-src/ext/zlib/zlib.c,v retrieving revision 1.183.2.6.2.8 diff -u -r1.183.2.6.2.8 zlib.c --- ext/zlib/zlib.c=0931 Dec 2008 11:17:47 -0000=091.183.2.6.2.8 +++ ext/zlib/zlib.c=0917 Feb 2009 22:13:40 -0000 @@ -979,7 +979,7 @@ { =09zend_bool do_start, do_end; -=09if (!ZLIBG(output_compression)) { +=09if (!ZLIBG(output_compression) || SG(sapi_headers).http_response_code =3D=3D 304) { =09=09*handled_output =3D NULL; =09} else { =09=09do_start =3D (mode & PHP_OUTPUT_HANDLER_START ? 1 : 0); Cheers, Edward --=20 PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php