Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43100
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Thu, 19 Feb 2009 00:14:47 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <8210197104.20090219001447@marcus-boerger.de>
To: Nathan Nobbe <quickshiftin@gmail.com>
CC: =?utf-8?Q?Johannes_Schl=C3=BCter?= <johannes@php.net>, 
	Antony Dovgal <tony@daylessday.org>, <internals@lists.php.net>
In-Reply-To: <7dd2dc0b0902180631q359a189aj5e4c54ef96d7f8e0@mail.gmail.com>
References: <7dd2dc0b0902172008g5a634577pad280d1f0415453b@mail.gmail.com> <499BC82B.2000000@daylessday.org> <1234963004.5869.6.camel@goldfinger> <7dd2dc0b0902180631q359a189aj5e4c54ef96d7f8e0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] zend_call_method() - support for up to 4 parameters
From: helly@php.net (Marcus Boerger)

Hello Nathan,

Wednesday, February 18, 2009, 3:31:56 PM, you wrote:

> On Wed, Feb 18, 2009 at 6:16 AM, Johannes Schlüter <johannes@php.net> wrote:

>> But I don't think that a new limitation is any better: Tomorrow we have
>> to change it again as somebody has a reason to use 5 parameters, so if
>> it is changed it should  be changed to take any number of arguments and
>> no fixed limit.... (or add a new API for that)


> that does seem ideal to me, but in the last thread, marcus was clear that an
> emalloc / va_list solution was unacceptable.  that was last january.. has
> anything changed in that regard since?

No.

> also, it sounded like he was saying a simple solution for up to 4 parameters
> would be alright. mainly i thought it would be nice to get it into the code
> for 5.3 before we'd have to wait for another major release in order to get
> something included.

Stuff like this can imo always be added and whether you do
#if PHP_VERSION_ID >= 50300
or
#if PHP_VERSION_ID >= 50301
imo doesn't matter much.

> yes, perhaps the function would need updating again in the future, but since
> people are using macros rather than zend_call_method directly it wouldnt be
> too bad right?

No. I think if you have a reasonable need for 4 paramters, then that's good
enough. On the other hand you shouldn't argue with me about 4 params :-)

> -nathan



Best regards,
 Marcus