Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20030314142807.0e2af870@127.0.0.1>
Date: Fri, 14 Mar 2003 14:28:52 +0200
To: Andrei Zmievski <andrei@gravitonic.com>,
	PHP Internals <internals@lists.php.net>
In-Reply-To: <20030313205122.GA21734@hyperion.gravitonic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] Doc comment patch
From: andi@zend.com (Andi Gutmans)
References: <20030313205122.GA21734@hyperion.gravitonic.com>

Hmm. I thought introspection is reflection. It seems I misunderstood.
Are you sure it's worth bloating the engine to hold this extra information?

Andi

At 03:51 PM 3/13/2003 -0500, Andrei Zmievski wrote:
>Pursuant to the introspection portion of TODO-PHP5, here is a small
>patch that:
>
>- Keeps track of starting/ending line numbers for user functions.
>- Removes extraneous T_ML_COMMENT token.
>- Stores the last seen doc comment (JavaDoc style) in the compiler
>   globals for future access by the introspection features and introduces
>   the new T_DOC_COMMENT token. The doc comment is defined as a multiline
>   comment starting with "/** \n" and ending with "*/". So, in the
>   following example:
>
>/**
>  * @name foo
>  * @param blah string
>  */
>function foo($blah)
>{
>}
>
>The CG(doc_comment) will contain:
>  * @name foo
>  * @param blah string
>
>What is left to do here is adding the T_DOC_COMMENT to parser rules and
>storing it in the appropriate structures (zend_op_array for functions,
>zend_class_entry for classes, etc).
>
>If no one objects, I will commit it shortly.
>
>-Andrei                                       http://www.gravitonic.com/
>
>The Feynman problem solving algorithm:
>
>1) Write down the problem.
>2) Think real hard.
>3) Write down the answer.
>
>--
>PHP Internals - PHP Runtime Development Mailing List
>To unsubscribe, visit: http://www.php.net/unsub.php