Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42902
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 209.85.162.183 cause and error)
Message-ID: <49888FDB.1070309@chiaraquartet.net>
Date: Tue, 03 Feb 2009 12:41:31 -0600
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807)
MIME-Version: 1.0
To: Lukas Kahwe Smith <mls@pooteeweet.org>
CC: php-dev List <internals@lists.php.net>
References: <5EC76153-898F-49C2-BDF1-C227578DB874@pooteeweet.org> <4454EC92-2977-4AF6-818F-49AE9F6F451B@pooteeweet.org>
In-Reply-To: <4454EC92-2977-4AF6-818F-49AE9F6F451B@pooteeweet.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] towards the next 5.3 release
From: greg@chiaraquartet.net (Greg Beaver)

Lukas Kahwe Smith wrote:
> Hi,
> 
> I also just reopened:
> http://bugs.php.net/bug.php?id=46026
> 
> Not sure if Greg has time ..

Actually, this was more complex than originally stated, in that this
code is incorrect:

if (SUCCESS == zend_hash_find(HASH_OF(filterparams), "concatenated",
sizeof("concatenated"), (void **) &tmpzval) ) {
-    SEPARATE_ZVAL(tmpzval);
-    convert_to_boolean_ex(tmpzval);
     data->expect_concatenated = Z_LVAL_PP(tmpzval);
-    zval_ptr_dtor(tmpzval);
     tmpzval = NULL;
}

The reason being that it incorrectly uses whatever the zval is, thus any
hash table or object would evaluate to true, even an empty array or object.

Thus, the correct fix is the one implemented in zlib_filter.c, and I've
ported it over.  It involves using a temporary zval, zval_copy_ctor()ing
it, and then convert_to_boolean_ex()ing it, which leaves the original
zval alone (the SEPARATE_ZVAL call does not do this properly), and
provides a valid boolean value.  I'll commit momentarily.

Greg