Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42857
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender)
To: Christopher Jones <christopher.jones@oracle.com>
Cc: "Nathanael D. Noblet" <nathanael@gnat.ca>, internals@lists.php.net
In-Reply-To: <497E5DF6.4060606@oracle.com>
References: <497E1FFB.5050404@gnat.ca>  <497E5DF6.4060606@oracle.com>
Content-Type: text/plain
Date: Tue, 27 Jan 2009 14:33:59 +0100
Message-ID: <1233063239.8505.10.camel@goldfinger>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] substr passing null...
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Mon, 2009-01-26 at 17:05 -0800, Christopher Jones wrote:
> 
> Nathanael D. Noblet wrote:
>  > Hello,
>  >   I just have a question, often there are 'optional' parameters to
>  > functions, I've always thought that most of the time I could pass null
>  > to these if I wanted to leave one empty. This has as far as I can tell
>  > always worked except recently I was using substr(). If I pass null to
>  > the third param, I get nothing back. Isn't passing null the same as not
>  > passing anything? Is this a bug? Or is my logic flawed?
>  >
>  >
> 
> I know Ilia recently fixed a few functions that didn't ignore null
> parameters, but it doesn't appear that substr() was one of them.

I guess that's part of the zend_parse_parameters changes. As we now use
the "s" modifier for instance which might better be a "s!". We should
certainly spent some time on checking these things.

All remember: We're feature freezing, so spend time on finding and
fixing bugs instead of adding new ones! :-)
(this includes users who can at least report such issues ... )

johannes