Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42681 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98158 invoked from network); 17 Jan 2009 22:26:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jan 2009 22:26:38 -0000 Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.21 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 209.85.218.21 mail-bw0-f21.google.com Received: from [209.85.218.21] ([209.85.218.21:59968] helo=mail-bw0-f21.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D0/8B-41390-D1B52794 for ; Sat, 17 Jan 2009 17:26:38 -0500 Received: by bwz14 with SMTP id 14so5962207bwz.23 for ; Sat, 17 Jan 2009 14:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=hJo6YQc+h5a2vilWLe2Ydz1Icfn8NbizY72xsAyWUO4=; b=eOFvqwbiwkAUq2jwbYtd5EAUOHelyJb6/gkNN7Q9o1JAWRxpzFW6r9L8wm3GAFRhxy TVXp6T/SjOUpIsDctOtHGRkdkq/7BLaufL4iC3I2pr2vXN0h/FSngW+a+zm5cRVQBCMi Go0vuLcGwdHX/TUy7/yN+B+cCDnPfCdzfX9vY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=sbmWe8cOo30ovc7aZKI9RH7rM33Bab9PnYfg8EbtjCeicC7mpIC/kooA8sC0Gn6eiJ g/PfDfPCnVpUvOKWP/sakRGkBRon8Pf5xhx7R8RRVKjghghGoxvjxWaaGklPy6KQ4gEZ 3XABd3aGnxjCMG5maIIqj707wesY90NcLlasA= MIME-Version: 1.0 Received: by 10.180.217.1 with SMTP id p1mr1407234bkg.147.1232231194687; Sat, 17 Jan 2009 14:26:34 -0800 (PST) In-Reply-To: <155749706.20090117211737@marcus-boerger.de> References: <155749706.20090117211737@marcus-boerger.de> Date: Sat, 17 Jan 2009 23:26:34 +0100 Message-ID: <7f3ed2c30901171426i4921f85bj333eb3677ba4d953@mail.gmail.com> To: Marcus Boerger Cc: Timm Friebe , internals@lists.php.net, Andi Gutmans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Method call improvements From: hannes.magnusson@gmail.com (Hannes Magnusson) (for the fun of it, I am CCing Andi, the CTO and senior VP of Zend) On Sat, Jan 17, 2009 at 21:17, Marcus Boerger wrote: > Hello Timm, > > Friday, January 16, 2009, 9:35:13 PM, you wrote: > >> * At [1d], calculate a hash key for the following: >> - method->name >> - ce->name >> - EG(scope) ? EG(scope)->name : "" >> These are the only variables used for verifying scope and >> modifiers, and the verification is always going to yield the >> same result as long as the stay the same. > > Aren't we able to bind these at least partially to the function call > opcode, in case we know they are constant? If all is constsnt we could > even store the whole lookup in the opcode. Well you'd have to convince > Zend to do that because os far they have always been against this > approach. Wait what? Wtf? Why would an opinion from a company matter to us? Sure. Dmitry does a kickass good job, but I can guarantee you that Arnaud, Felipe, Tony and youself could do just as good job. If I was king (with m4d skillz) I would fork that "Zend engine", try to fix the license (which lies, there is no way of "downloading the engine" from their website) and try to optimize things as much as possible before it ever hits (almost non-existing) optimizers. By saying this kind of things Marcus you make me very scared. You shouldn't care what Zend, Yahoo, Facebook or whatever company says. If you think it is the right decision then (quoting Christina Aguilera ;) ) "Do your thing honey!" You were well on-track with your Closures commits, unfortunately that didn't turn out quite as well neither of us had hoped for, but that is life. Sometimes your ideas don't work out. Sometimes they do. It hasn't stopped you so far, so why would it now? -Hannes