Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42664 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88367 invoked from network); 16 Jan 2009 17:38:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jan 2009 17:38:48 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.133 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.133 mailout1.netbeat.de Linux 2.6 Received: from [83.243.58.133] ([83.243.58.133:51725] helo=mailout1.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D8/8C-27029-626C0794 for ; Fri, 16 Jan 2009 12:38:47 -0500 Received: (qmail 7971 invoked by uid 89); 16 Jan 2009 17:49:10 -0000 Received: from unknown (HELO ?192.168.1.103?) (johannes%schlueters.de@82.135.2.1) by mailout1.netbeat.de with ESMTPA; 16 Jan 2009 17:49:10 -0000 To: Stanislav Malyshev Cc: 'PHP Internals' In-Reply-To: <496FDDD3.9000102@zend.com> References: <496FDDD3.9000102@zend.com> Content-Type: text/plain Date: Fri, 16 Jan 2009 18:38:38 +0100 Message-ID: <1232127518.8220.25.camel@goldfinger> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [patch] build_id implementation From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Thu, 2009-01-15 at 17:07 -0800, Stanislav Malyshev wrote: > Index: Zend/zend_modules.h [...] > @@ -70,8 +68,7 @@ > struct _zend_module_entry { > unsigned short size; > unsigned int zend_api; > - unsigned char zend_debug; > - unsigned char zts; > + char *build_id; > const struct _zend_ini_entry *ini_entry; > const struct _zend_module_dep *deps; > const char *name; If I got it right it will, when loading a 5.3 extension in 5.2, try to read the extension name from the wrong location and therefor most likely segfault while generating the error message. (it will also try to read zend_debug and zts, of course, but there it should be able to safely read random data) So I'd like to keep the structure in a way that the offset to the name pointer is still he same. johannes