Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42621 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80048 invoked from network); 14 Jan 2009 17:39:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Jan 2009 17:39:24 -0000 Authentication-Results: pb1.pair.com header.from=typoon@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=typoon@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.170.187 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: typoon@gmail.com X-Host-Fingerprint: 64.233.170.187 rn-out-0910.google.com Received: from [64.233.170.187] ([64.233.170.187:10350] helo=rn-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5E/FD-14662-B432E694 for ; Wed, 14 Jan 2009 12:39:23 -0500 Received: by rn-out-0910.google.com with SMTP id k40so543981rnd.0 for ; Wed, 14 Jan 2009 09:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=+YF6W56BDqMbSd3BM4MNVhkovwHwawuak9P1IwMdD0w=; b=EsD1goFfXgvG7pb//oMnoUrFZkPijPE7RVvJy1heNuHttkYm/6gAKLw13EPzLwJY2X OUQ1offSZ/xkDjNYHj6p4b40Lblnm2NKCAvFotZV+MV6h/mlt1FkUVSQS3FfhitWJjfH 4/SCAqNdYKqOD7T253kiTPwUfRQKAXU1kX52Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=HNplgrj+lsyT5YPEnyem8nrcAKdTi8EZO/192CakYgwBGeRdlhmzFyF/Yi6BIb89k3 aGLoy4uTMjrNlyfOObTxQKlasFOkFsBRY3OX1ikoDAKUIIa2PcHiM3WoPCXsc986fFlj 6J6Acj/acpS9a113B/D2s2Utaiv5q890gAa7Y= Received: by 10.100.140.1 with SMTP id n1mr389032and.13.1231954760462; Wed, 14 Jan 2009 09:39:20 -0800 (PST) Received: by 10.100.123.1 with HTTP; Wed, 14 Jan 2009 09:39:20 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2009 11:39:20 -0600 To: internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4664_938566.1231954760451" References: Subject: Re: [PATCH] Bug 47002 - Fields truncated From: typoon@gmail.com ("Henrique M. Decaria") ------=_Part_4664_938566.1231954760451 Content-Type: multipart/alternative; boundary="----=_Part_4665_4204801.1231954760451" ------=_Part_4665_4204801.1231954760451 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Oh, I missed one thing. I also had to fix test 001.phpt Attached is the patch for it, which can also be found in the following url: http://felipe.ath.cx/typoon/001.phpt.diff.txt Sorry for the confusion :$ Thanks! Henrique On Wed, Jan 14, 2009 at 11:16 AM, Henrique M. Decaria wrote: > Greetings PHP people, > > I have written a patch to resolve the issue mentioned in the subject. Also > I wrote a small test case for it. This patch is to be applied on PHP5_2 CVS. > Still in this matter, I have written a patch for dbase.c (this was based on > Felipe's patch which seems to have been lost) to use zend_parse_parameters > and also to check for the PHP version to define if the arginfo should > receive a static identifier or not. > The patches are attached, and so is the test case. > These files can also be found in the following URLs: > > Patch for the bug: > http://felipe.ath.cx/typoon/dbase_php5.2.9_bug47002.diff > Patch for dbase.c: http://felipe.ath.cx/typoon/dbase_php5.2.9.diff > Test case for the bug: http://felipe.ath.cx/typoon/bug47002.phpt > > Currently I am also working on getting the dbase fixed in the PECL > repositories so we can have a release (just finishing writing some test > cases). > > In case there are any doubts or problems, please let me know so I can > verify. > > BTW, I am Gilgamesh on #php.pecl (sometimes shows up as typoon because of > problems with mibbit). So you can also contact me there :) > > Thanks! > > Henrique > ------=_Part_4665_4204801.1231954760451 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Oh, I missed one thing.
I also had to fix test 001.phpt
Attached is the patch for it, which can also be found in the following url:
http://felipe.ath.cx/typoon/001.phpt.diff.txt

Sorry for the confusion :$

Thanks!

Henrique

On Wed, Jan 14, 2009 at 11:16 AM, Henrique M. Decaria <typoon@gmail.com> wrote:
Greetings PHP people,

I have written a patch to resolve the issue mentioned in the subject. Also I wrote a small test case for it. This patch is to be applied on PHP5_2 CVS.
Still in this matter, I have written a patch for dbase.c (this was based on Felipe's patch which seems to have been lost) to use zend_parse_parameters and also to check for the PHP version to define if the arginfo should receive a static identifier or not.
The patches are attached, and so is the test case.
These files can also be found in the following URLs:

Patch for the bug: http://felipe.ath.cx/typoon/dbase_php5.2.9_bug47002.diff
Patch for dbase.c: http://felipe.ath.cx/typoon/dbase_php5.2.9.diff
Test case for the bug: http://felipe.ath.cx/typoon/bug47002.phpt

Currently I am also working on getting the dbase fixed in the PECL repositories so we can have a release (just finishing writing some test cases).

In case there are any doubts or problems, please let me know so I can verify.

BTW, I am Gilgamesh on #php.pecl (sometimes shows up as typoon because of problems with mibbit). So you can also contact me there :)

Thanks!

Henrique

------=_Part_4665_4204801.1231954760451-- ------=_Part_4664_938566.1231954760451 Content-Type: text/plain; name=001.phpt.diff.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fpy9y1u33 Content-Disposition: attachment; filename=001.phpt.diff.txt SW5kZXg6IGV4dC9kYmFzZS90ZXN0cy8wMDEucGhwdAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvcmVw b3NpdG9yeS9waHAtc3JjL2V4dC9kYmFzZS90ZXN0cy9BdHRpYy8wMDEucGhwdCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xLjIuMgpkaWZmIC11IC11IC13IC1iIC1yMS4xLjIuMiAwMDEucGhwdAot LS0gZXh0L2RiYXNlL3Rlc3RzLzAwMS5waHB0CTI1IEZlYiAyMDA3IDIzOjE3OjEyIC0wMDAwCTEu MS4yLjIKKysrIGV4dC9kYmFzZS90ZXN0cy8wMDEucGhwdAkxNCBKYW4gMjAwOSAxNzozNDoyOCAt MDAwMApAQCAtNTUsOSArNTUsOSBAQAogV2FybmluZzogZGJhc2VfY3JlYXRlKCk6IFVuYWJsZSB0 byBjcmVhdGUgZGF0YWJhc2Ugd2l0aG91dCBmaWVsZHMgaW4gJXMgb24gbGluZSAlZAogYm9vbChm YWxzZSkKIAotV2FybmluZzogZGJhc2VfY3JlYXRlKCk6IEV4cGVjdGVkIGFycmF5IGFzIHNlY29u ZCBwYXJhbWV0ZXIgaW4gJXMgb24gbGluZSAlZAotYm9vbChmYWxzZSkKK1dhcm5pbmc6IGRiYXNl X2NyZWF0ZSgpIGV4cGVjdHMgcGFyYW1ldGVyIDIgdG8gYmUgYXJyYXksIGludGVnZXIgZ2l2ZW4g aW4gJXMgb24gbGluZSAlZAorTlVMTAogCi1XYXJuaW5nOiBkYmFzZV9jcmVhdGUoKTogRXhwZWN0 ZWQgYXJyYXkgYXMgc2Vjb25kIHBhcmFtZXRlciBpbiAlcyBvbiBsaW5lICVkCi1ib29sKGZhbHNl KQorV2FybmluZzogZGJhc2VfY3JlYXRlKCkgZXhwZWN0cyBwYXJhbWV0ZXIgMiB0byBiZSBhcnJh eSwgc3RyaW5nIGdpdmVuIGluICVzIG9uIGxpbmUgJWQKK05VTEwKIERvbmUK ------=_Part_4664_938566.1231954760451--