Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42516
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.153 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=qUkbSPzWBWGQBxlzmmjTczbqd85sHUfSZa8jPjdu0/HfsPnWlEWv4LLuqzJtN3sKgB
         FI+WQTdr4SedbeJhdmf+A2/GAN+4TM4MIdwH5N/VasJa6MhIdP/Zbg8fb5h6fjPjebn/
         C17zmQAuUjghdbM4kpBm0BxkKzuDhO5CQAgVY=
Message-ID: <fe05d1540901061209r28aef973ucae4cf9f47443ed2@mail.gmail.com>
Date: Tue, 6 Jan 2009 21:09:13 +0100
To: "Hannes Magnusson" <hannes.magnusson@gmail.com>
Cc: "PHP Developers Mailing List" <internals@lists.php.net>, 
	"Dmitry Stogov" <dmitry@zend.com>, 
	"Stanislav Malyshev" <stas@zend.com>
In-Reply-To: <7f3ed2c30901061200y6c6177d1p1b435766bbe77554@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <fe05d1540901060938t4aff6b7ag15d7a8e9055b8bf9@mail.gmail.com>
	 <7f3ed2c30901061200y6c6177d1p1b435766bbe77554@mail.gmail.com>
Subject: Re: [PHP-DEV] regression in the new parameter parsing API, 5.3
From: pierre.php@gmail.com ("Pierre Joye")

On Tue, Jan 6, 2009 at 9:00 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Tue, Jan 6, 2009 at 18:38, Pierre Joye <pierre.php@gmail.com> wrote:
>> hi,
>>
>> The new parameter parser introduced a regression (testing with
>> 5.3-cvs) on how "z!" is processed. Example code:
>>
>> if (0) {
>>        $authns = 1;
>>        $addtl = 1;
>> }
>> $result = dns_get_record("php.net", DNS_ANY, $authns, $addtl);
>> print_r($result);
>> var_dump($authns);
>> var_dump($addtl);
>>
>> With 5.2, $authns and $addtl are correctly set (zval ptr is not NULL)
>> but 5.3 gives NULL. Sorry to do not try to fix it myself, I sadly lack
>> the time to take care of that right now.
>
> Its not the API that is b0rking things, its the full rewrite of the function.
>
> z! means C NULL, not a zval IS_NULL, so the if (authns) and if (addtl)
> checks will only kick in if the variables were initialized.

It is still a regression. The same code worked in 5.2.x but returns
nothing in 5.3+. We can argue than no notice (undefined variable) was
raised in 5.2 (or 5.3), but it worked and should still work, imo.

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org