Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42497
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain prohost.org from 74.125.44.28 cause and error)
Cc: Brian Shire <shire@php.net>,
 PHP Developers Mailing List <internals@lists.php.net>
Message-ID: <BC33944B-F813-406A-9D34-774976BA8794@prohost.org>
To: Felipe Pena <felipensp@gmail.com>
In-Reply-To: <1231187760.3220.2.camel@pena>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Mon, 5 Jan 2009 18:35:19 -0500
References: <495EF18A.7040206@php.net>  <1230985623.3243.3.camel@pena> <1230985890.3243.6.camel@pena> <1230988421.3243.8.camel@pena> <495FBA65.4030001@php.net> <1231187760.3220.2.camel@pena>
Subject: Re: [PHP-DEV] PATCH: bug #46701
From: ilia@prohost.org (Ilia Alshanetsky)

The fix looks to be safe enough to MFH, I see no API breakage.


On 5-Jan-09, at 3:36 PM, Felipe Pena wrote:

> Hi,
>
> Em S=E1b, 2009-01-03 =E0s 11:20 -0800, shire escreveu:
>> Felipe Pena wrote:
>>> Em S=E1b, 2009-01-03 =E0s 10:31 -0200, Felipe Pena escreveu:
>>>> Em S=E1b, 2009-01-03 =E0s 10:27 -0200, Felipe Pena escreveu:
>>>>> Em Sex, 2009-01-02 =E0s 21:03 -0800, shire escreveu:
>>>>>> I've created a patch for bug #46701 =
(http://bugs.php.net/bug.php?id=3D46701=20
>>>>>> ) but it requires Zend changes, it can be found at the links =20
>>>>>> below for all branches.  I've verified all tests pass.  We may =20=

>>>>>> want to verify it for other architectures due to the nature of =20=

>>>>>> it being a float conversion problem, I tested on Intel OS X =20
>>>>>> 10.5.5.  But this should at least be equivalent to =20
>>>>>> $array[intval($double)] now.
>>>>>>
>>>>>>
>>>>>> http://tekrat.com/patches/bug46701.php6.patch
>>>>>> http://tekrat.com/patches/bug46701.php53.patch
>>>>>> http://tekrat.com/patches/bug46701.php52.patch
>>>>>>
>>>>>>
>>>>> I suppose that should we also change the fetch (ZEND_FETCH_DIM_*)?
>>>>>
>>>>> And probably:
>>>>> 		case IS_DOUBLE:
>>>>> 			index =3D (long)Z_DVAL_P(dim);
>>>>> 			goto num_index;
>>>>>
>>>>> And zend_execute.c (zend_fetch_dimension_address_inner) will be
>>>>> superfluous with this change.
>>>> Errr, I mean, the case IS_DOUBLE stuff in
>>>> zend_fetch_dimension_address_inner will be superfluous.
>>>>
>>>
>>>
>>> In the end, I see that it requires the macro too, hehe.
>>> So, a little change in your patch:
>>>
>>> -		case IS_DOUBLE:
>>> -			index =3D (long)Z_DVAL_P(dim);
>>> +		case IS_DOUBLE: {
>>> +			DVAL_TO_LVAL(Z_DVAL_P(dim), index);
>>>  			goto num_index;
>>> -
>>> +		}
>>>
>>
>> Hey, Good point Felipe, thanks!  I've updated my  patches as well =20
>> to include this change and verified all the tests.
>>
>
> I've committed it in 5_3 and HEAD. Ilia, should it be in 5_2 too?
>
> Thanks for the patch, Shire. ;)
>
> --=20
> Regards,
> Felipe Pena
>

Ilia Alshanetsky