Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42473
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mozo.jp from 209.85.142.189 cause and error)
Message-ID: <495F9578.6090609@mozo.jp>
Date: Sun, 04 Jan 2009 01:42:32 +0900
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1b3pre) Gecko/20081204 Thunderbird/3.0b1
MIME-Version: 1.0
To: "Henrique M. Decaria" <typoon@gmail.com>
CC: internals@lists.php.net
References: <f427fa540812300824v54cb2c65r7bde3ea87e8e0663@mail.gmail.com>
In-Reply-To: <f427fa540812300824v54cb2c65r7bde3ea87e8e0663@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Bug #46806 - mb_strimwidth
From: mozo@mozo.jp (Moriyoshi Koizumi)

Hi,

This behavior seems strange, but the rationale of this function is that 
the (east asian) width of the resulting string does not exceed the 
specified value so that it would fit to a fixed sized box when rendered 
in the browser, assuming the string would be displayed with a monospace 
font.  So, it is the document that is wrong.

Regards,
Moriyoshi

(2008/12/31 1:24), Henrique M. Decaria wrote:
> Hello guys,
>
> Looking in the subject mentioned bug report, it seems that the attached
> patch might do the trick and make the mb_strimwidth() function work as
> explained in the php manual (http://br2.php.net/mb_strimwidth).
> According to it, the function should trim up to the defined width and append
> the trimmarker, that being said, the following code should return "hello..."
> not "he..."
>
> echo mb_strimwidth('helloworld', 0, 5, '...', 'UTF-8');
>
> The change in the file is:
>
> -    pc.width = width - mkwidth;
> +    pc.width = width;
>
> I am not sure why there is this "- mkwidth" there, but it seems to be used
> to remove the last "mkwidth" characters from the trimmed string so it would
> be replaced with the trimmarker.
>
> It could be that the test file for this function is incorrect (i can't
> guarantee as I am having issues with Japanese characters here). So please,
> if you could have a look and see if it works as expected with this patch it
> would be great.
>
> Thanks,
>
> Henrique
>
>


-- 
-- moriyoshi