Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42457
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.44.30 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=XQdlzBIJipFlqPD7oJFs0+BjDSibYBLYWE+ItdVkKTZ5wlH0bOpsJmaOyoileXk7Ks
         TVBPgMioJ+6G+FTsZUoE5ulbv7qcvKiHVNuqoZAjLzgN1Hfi3WGdQ9YnzOlw6WqwRKNY
         lQdrcHypVr0HZcvM8gzvpDcg8U95xUOedz/fw=
To: shire@php.net
Cc: PHP Internals List <internals@lists.php.net>
In-Reply-To: <495EF18A.7040206@php.net>
References: <495EF18A.7040206@php.net>
Content-Type: text/plain; charset=utf-8
Date: Sat, 03 Jan 2009 10:27:03 -0200
Message-ID: <1230985623.3243.3.camel@pena>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PATCH: bug #46701
From: felipensp@gmail.com (Felipe Pena)

Em Sex, 2009-01-02 às 21:03 -0800, shire escreveu:
> I've created a patch for bug #46701 (http://bugs.php.net/bug.php?id=46701) but it requires Zend changes, it can be found at the links below for all branches.  I've verified all tests pass.  We may want to verify it for other architectures due to the nature of it being a float conversion problem, I tested on Intel OS X 10.5.5.  But this should at least be equivalent to $array[intval($double)] now.
> 
> 
> http://tekrat.com/patches/bug46701.php6.patch
> http://tekrat.com/patches/bug46701.php53.patch
> http://tekrat.com/patches/bug46701.php52.patch
> 
> 

I suppose that should we also change the fetch (ZEND_FETCH_DIM_*)?

And probably:
		case IS_DOUBLE:
			index = (long)Z_DVAL_P(dim);
			goto num_index;

And zend_execute.c (zend_fetch_dimension_address_inner) will be
superfluous with this change.


> Thanks,
> -shire
> 
-- 
Regards,
Felipe Pena