Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42380 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28878 invoked from network); 26 Dec 2008 11:27:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Dec 2008 11:27:46 -0000 Authentication-Results: pb1.pair.com smtp.mail=drwoland@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=drwoland@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.21 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: drwoland@gmail.com X-Host-Fingerprint: 209.85.218.21 mail-bw0-f21.google.com Received: from [209.85.218.21] ([209.85.218.21:37043] helo=mail-bw0-f21.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 44/C4-33750-1BFB4594 for ; Fri, 26 Dec 2008 06:27:46 -0500 Received: by bwz14 with SMTP id 14so9971057bwz.23 for ; Fri, 26 Dec 2008 03:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type:references :x-google-sender-auth; bh=biy0BmvamWxk0tf0Y002v+rza9AESQiPA6CL9+Zmy0s=; b=o+mZwU7/+e4TrS9zZ4GrLsRWX4vl+GBgJjL8SbpuuaMR3tB8XF/m0teeR75icH1OGu MpOdzXc04V4QT9306nchTGzrwW/ZVR/GK3jAUZEb+Peys+WZmPuIEKmZVj8/4LgZQMz5 78Pym5+j7VLuc6AuliMElRWTHJ04no920L1Hw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:references:x-google-sender-auth; b=eBt48zKSz8pWuG3snLZEuUvbIdAjRB37WRrrlC8RVKQOzzQzUsgDrp7vxMeR5BR4WX PdKR4mFG2/burxiVyvG2LGTyaiIfZUy5FFZzg4JKp/TjMQHkRv57PZCkr5qhboaU0BJ7 0gaSfGu/h9mIIlVoDfHycmpmgrjqwWBO8ir3c= Received: by 10.181.205.9 with SMTP id h9mr3937003bkq.196.1230290862414; Fri, 26 Dec 2008 03:27:42 -0800 (PST) Received: by 10.181.227.16 with HTTP; Fri, 26 Dec 2008 03:27:42 -0800 (PST) Message-ID: <5faa7b820812260327j2e1d3c3hfe46e0259431a4e7@mail.gmail.com> Date: Fri, 26 Dec 2008 03:27:42 -0800 Sender: drwoland@gmail.com To: "Alexey Zakhlestin" Cc: "David Coallier" , internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_120649_16958786.1230290862407" References: <5faa7b820812260106p6f24bf0ct49ef574e5ed4e2c2@mail.gmail.com> X-Google-Sender-Auth: be7a5d275c6a35d4 Subject: Re: [PHP-DEV] Proposal: array_flatten function From: m@mihasya.com ("Mike Panchenko") ------=_Part_120649_16958786.1230290862407 Content-Type: multipart/alternative; boundary="----=_Part_120650_9995611.1230290862407" ------=_Part_120650_9995611.1230290862407 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Well, I've made a patch against 5.3 for now, let me know if there are issues with it (I'm sure there are) and if you want the HEAD patch. Cheers. Mike. On Fri, Dec 26, 2008 at 2:55 AM, Alexey Zakhlestin wrote: > On Fri, Dec 26, 2008 at 1:43 PM, David Coallier wrote: > >> > >> "cvs diff -u" against 5.3 branch shoould be ok for the start. > >> after positive review, "cvs diff -u" against HEAD would be needed to > >> > > > > I really have to say it, you should make your changes to HEAD > > __first__ then to 5.3. Not the other way around :) > > David, it's not about changes. It's about review. > Raw fact is, that reviewing on 5.3 is much easier than on HEAD for many > people. > > At the moment of commit both patches are needed, for sure :) > > -- > Alexey Zakhlestin > http://www.milkfarmsoft.com/ > ------=_Part_120650_9995611.1230290862407 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Well, I've made a patch against 5.3 for now, let me know if there are issues with it (I'm sure there are) and if you want the HEAD patch. Cheers.

Mike.

On Fri, Dec 26, 2008 at 2:55 AM, Alexey Zakhlestin <indeyets@gmail.com> wrote:
On Fri, Dec 26, 2008 at 1:43 PM, David Coallier <davidc@php.net> wrote:
>>
>> "cvs diff -u" against 5.3 branch shoould be ok for the start.
>> after positive review, "cvs diff -u" against HEAD would be needed to
>>
>
> I really have to say it, you should make your changes to HEAD
> __first__ then to 5.3. Not the other way around :)

David, it's not about changes. It's about review.
Raw fact is, that reviewing on 5.3 is much easier than on HEAD for many people.

At the moment of commit both patches are needed, for sure :)

--
Alexey Zakhlestin
http://www.milkfarmsoft.com/

------=_Part_120650_9995611.1230290862407-- ------=_Part_120649_16958786.1230290862407--