Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42219
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.142.184 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:mime-version:content-type
         :content-transfer-encoding:content-disposition:x-google-sender-auth;
        b=EWX8gLoHxb1gN2hGvtmhqo2RTGa2+451yWHl9i/QE+GS0TY886NBcvpoYR9ZYXqd/Z
         s2onVAW3rSl6ByVVE1+N7TyMUFyWiSsXxNsWqUTNdnEtZYAsxlXwx2K12CguSfprfKWX
         NXLs6OzqwGwVuFeMl9kt32bvYgCJv1MGkLbNQ=
Message-ID: <28139bc0812112121v2263ec2am1e603bf008bb1ecf@mail.gmail.com>
Date: Fri, 12 Dec 2008 13:21:32 +0800
Sender: xuefer@gmail.com
To: "PHP Developers Mailing List" <internals@lists.php.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: 5.3 compile time still depends on runtime constants ("Default value for parameters with a class type hint can only be NULL")
From: phpxcache@gmail.com (phpxcache)

this is a discussion about "Default value for parameters with a class
type hint can only be NULL" error

let's focus our eyes on
====  zend_compile.c function zend_do_receive_arg
void zend_do_receive_arg(zend_uchar op, const znode *var, const znode
*offset, const znode *initialization, znode *class_type, const znode
*varname, zend_uchar pass_by_reference TSRMLS_DC)
{
...........
            if (op == ZEND_RECV_INIT) {
                if (Z_TYPE(initialization->u.constant) == IS_NULL ||
(Z_TYPE(initialization->u.constant) == IS_CONSTANT &&
!strcasecmp(Z_STRVAL(initialization->u.constant), "NULL"))) {
                    cur_arg_info->allow_null = 1;
                } else {
                    zend_error(E_COMPILE_ERROR, "Default value for
parameters with a class type hint can only be NULL");
                }
            }
====test.php======
<?php
namespace My\NS;

use My\NS;

class A {
    public function test(A $obj=null) {
        var_dump($obj);
    }
}
================

(the following gdb input/output is still using macro for your reading,
expand the macro if you want to execute)

test case 1
precondition: CG(compiler_options) |= ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION;
break at function zend_do_receive_arg and
(gdb) print Z_TYPE(initialization->u.constant) == IS_NULL
1 (true)
which means it still "subst null to IS_NULL"

test case 2
precondtion: let's assume ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION is
working for zend_do_receive_arg, simply empty hash table
EG(zend_constants) = &an_empty_hash_table before zend_compile_file
break at function zend_do_receive_arg and
(gdb) print Z_TYPE(initialization->u.constant) == IS_NULL
0 (false)
(gdb) print Z_TYPE(initialization->u.constant) == IS_CONSTANT
0 (false)

so what is that?
(gdb) print Z_TYPE(initialization->u.constant)
24
(gdb) print (Z_TYPE(initialization->u.constant) &
IS_CONSTANT_TYPE_MASK) == IS_CONSTANT
1 (true)
************ ok, we get the first bug
(gdb) p !strcasecmp(Z_STRVAL(initialization->u.constant), "NULL"))
0 (false)
why?
(gdb) p Z_STRVAL(initialization->u.constant)
"My\\NS\\null"
this is the reason. looks likestrcasecmp is not enough here at compile
time. or you could just handle abc(array $a = null) as a special case?