Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42194
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.154 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=gsRFpknQiME4xCkfxRpIfPMkQCfdAyMObR1vXA5Q4tQtef34oe6CmZDJ0ZAEZLCTiD
         pYd1J//aqKfXKqzYll5u5DXh2n0aC+vGYtViq6/7knicsBFRsa7gsAhCJKZ19f9RmNsV
         Urq4Gk4uHLzTeIk9MBS/SDpkN8ewtmgNjhTOY=
Message-ID: <7f3ed2c30812082351s87b3db6w94b4b2f23a636591@mail.gmail.com>
Date: Tue, 9 Dec 2008 08:51:36 +0100
To: "Lukas Kahwe Smith" <mls@pooteeweet.org>, 
	"=?ISO-8859-1?Q?Johannes_Schl=FCter?=" <johannes@php.net>
Cc: "Pierre Joye" <pierre.php@gmail.com>, "Ilia Alshanetsky" <ilia@prohost.org>, 
	"Marcus Boerger" <helly@php.net>, 
	"Scott MacVicar" <scott@macvicar.net>, 
	"PHP Internals" <internals@lists.php.net>
In-Reply-To: <70D75F35-4810-4CA0-BB35-35B11BFE1296@pooteeweet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <40E11268-D705-4F32-96E0-4C0AEA27AAC9@macvicar.net>
	 <BE107CA1-A1B3-4429-9E5F-056F94A05A94@prohost.org>
	 <1349302921.20081207193342@marcus-boerger.de>
	 <DE53E110-C7BB-4B13-A642-07DA0177E205@prohost.org>
	 <fe05d1540812080624n33ca8672o5c179d628e351615@mail.gmail.com>
	 <7f3ed2c30812080706y1300c22cg61337b24fbfc2936@mail.gmail.com>
	 <fe05d1540812080708q16829c68l30a33fff7bfaee0f@mail.gmail.com>
	 <70D75F35-4810-4CA0-BB35-35B11BFE1296@pooteeweet.org>
Subject: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken
From: hannes.magnusson@gmail.com ("Hannes Magnusson")

On Mon, Dec 8, 2008 at 22:40, Lukas Kahwe Smith <mls@pooteeweet.org> wrote:
>
> On 08.12.2008, at 16:08, Pierre Joye wrote:
>
>> On Mon, Dec 8, 2008 at 4:06 PM, Hannes Magnusson
>> <hannes.magnusson@gmail.com> wrote:
>>>
>>> On Mon, Dec 8, 2008 at 15:24, Pierre Joye <pierre.php@gmail.com> wrote:
>>>>
>>>> hi,
>>>>
>>>> On Mon, Dec 8, 2008 at 3:15 PM, Ilia Alshanetsky <ilia@prohost.org>
>>>> wrote:
>>>>>
>>>>> Should the 5.3 release be re-branched perhaps as well, since it too has
>>>>> this
>>>>> problem?
>>>>
>>>> I do not think it is necessary for 5.3. It is an alpha release after
>>>> all and seriously, anyone who plans to move to 5.3.0 and still relies
>>>> on magic quotes gpc is likely to have more issues as well.
>>>
>>> Time to turn it off by default then?
>>
>> I would even like to drop it (and the other things as well) in 5.3.0 :)
>
>
> the drop was planned for 6.0 for a reason.
> i also do not think we need to make a 5.3 release just for this.
> lets focus on getting feedback on namespaces and the other changes and have
> this fixed on beta1 early 2009.
>
> adding an E_DEPRECATE (actually i guess we should check the PHP6 NEWS file
> for other stuff as well), does make sense.
> disabling by default (if not yet done) too.

http://phpfi.com/386386

Removed stuff (in 6) disabled by default and throws E_DEPRECATED when activated.
set_magic_quotes_runtime() and its evil twin magic_quotes_runtime()
already use PHP_DEP_FE/_FALIAS.
The getters (get_magic_quotes_gpc() and get_magic_quotes_runtime())
should IMO not spew E_DEPRECATED warnings (and they do not currently,
nor after the patch above).

Any objections?

-Hannes