Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42122 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40774 invoked from network); 6 Dec 2008 10:25:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Dec 2008 10:25:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=igor.feghali@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=igor.feghali@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.221.20 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: igor.feghali@gmail.com X-Host-Fingerprint: 209.85.221.20 mail-qy0-f20.google.com Received: from [209.85.221.20] ([209.85.221.20:44546] helo=mail-qy0-f20.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 01/BD-01047-E235A394 for ; Sat, 06 Dec 2008 05:25:51 -0500 Received: by qyk13 with SMTP id 13so502220qyk.23 for ; Sat, 06 Dec 2008 02:25:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=VZhh5W7/bb6kvOrX5IMnW8QvlSKdljuwNnH7qAC7b5k=; b=bTTVs/fMRW07xOu/+YQSD+W2a5c7YVEDWEZdkl1v+LYTvBEYSYMHDMOOAqbISr9cj8 GSfsmLcpUvbsPO8bHVIjtNCOZd3bzrJDdAw9kru8ZbN3R8n020TCH8HzMAw9s0hN/Vmm teQWGnG6zwOE6Zdcl9gSFLE60p8mz6/wPTE90= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=HT8b7Iuo/meI0VpgYNd0+l6BFjsGrE5hM7jQDMeVGWv6pJqgmCy0/031uf0P2F9qui uvYbeDFB9JMXOgMbk7vCQtP0DkN/WeIqI3nhOsgjvo5Uhh2CI20vEOMrkQIOv5IUQd1s SGgrwzG3NbCE5snYRJfnGB1RRW9BORa1RrTQ0= Received: by 10.215.66.20 with SMTP id t20mr1034819qak.330.1228559147423; Sat, 06 Dec 2008 02:25:47 -0800 (PST) Received: by 10.214.115.21 with HTTP; Sat, 6 Dec 2008 02:25:47 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2008 08:25:47 -0200 To: "Kenan R Sulayman" Cc: "PHP Internals List" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Subject: Re: [PHP-DEV] Implode() FR and Patch From: igor.feghali@gmail.com ("Igor Feghali") Hello Kenan, Thank you for your feedback. On Sat, Dec 6, 2008 at 07:41, Kenan R Sulayman wrote: > A question: hasn't the new one got a better performance ? According to my tests I would say they perform are equal. Please let me know if you did any deeper tests. PS: on string.c where one read : implstr.len--; should be: implstr.len -= Z_STRLEN_P(delim); Best Regards, Igor Feghali.