Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:42119
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.170.184 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type;
        b=jY8dnrJ+qnQGZ6Y4ktYHkwzMS+UqIszNcEOfNhvExPUgvxWKbtxbzoPopqfZBNQCuK
         bYx/HWIo1KTKooRrWDyULfy6UqzezaBOUxA5M4uFklYv/It/oKmlytK3slAWK9DnIjX0
         vOXvfQftMwfhkLawiDzVjov39mEBk+3/CikhY=
Message-ID: <ade4f020812051821l629769dby1fd65c476ad6a8ef@mail.gmail.com>
Date: Sat, 6 Dec 2008 00:21:21 -0200
To: "PHP Internals List" <internals@lists.php.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_25571_12489736.1228530081694"
Subject: Implode() FR and Patch
From: igor.feghali@gmail.com ("Igor Feghali")

------=_Part_25571_12489736.1228530081694
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hello There,

I would like to propose a third argument to implode(), named
skip_empty, that will cause empty elements to be ignored when
generating the implode string. By empty I mean everything that
converts to an empty string such as '', false, null, etc.

For example:

<?php
$a = array(1,'',2,null,3,0,4,true,5,false,false);
echo implode(',', $a); // old behavior
echo "\n";
echo implode(',', $a, true); // new feature
echo "\n";
echo $foo;
echo "\n";
?>

Will output:

1,,2,,3,0,4,1,5,,
1,2,3,0,4,1,5

Obviously the new parameter defaults to 'false' for backwards compatibility.

The patch file is attached for evaluation, review, feedback etc.
Please keep in mind that this is my first time playing with PHP source
so expect flaws on my code.

I did a few simple tests (using `time`, if someone has a non buggy
valgrind for OS X please let me know) against 5.3 CVS (named php53 in
examples) and my patched version (named php+ in examples). The PHP
scripts are right below the tests. Looking at the results I would say
there is almost no performance loss.

Before I place a feature request at PHP.net I would love to hear some
feedback here, or even a yes/no for this feature.

Best Regards,
Igor Feghali.

=== TEST 1 ===
$ time ./php53 /tmp/more_small.php
real    0m0.257s
user    0m0.223s
sys     0m0.032s

$ time ./php53 /tmp/more_small.php
real    0m0.258s
user    0m0.224s
sys     0m0.032s

$ time ./php53 /tmp/more_small.php
real    0m0.260s
user    0m0.225s
sys     0m0.032s

$ time ./php+ /tmp/more_small.php
real    0m0.261s
user    0m0.226s
sys     0m0.033s

$ time ./php+ /tmp/more_small.php
real    0m0.258s
user    0m0.224s
sys     0m0.032s

$ time ./php+ /tmp/more_small.php
real    0m0.260s
user    0m0.225s
sys     0m0.033s


=== TEST 2 ===
$ time ./php53 /tmp/less_big.php
real    0m0.328s
user    0m0.205s
sys     0m0.120s

$ time ./php53 /tmp/less_big.php
real    0m0.328s
user    0m0.206s
sys     0m0.120s

$ time ./php53 /tmp/less_big.php
real    0m0.326s
user    0m0.205s
sys     0m0.119s

$ time ./php+ /tmp/less_big.php
real    0m0.330s
user    0m0.206s
sys     0m0.122s

$ time ./php+ /tmp/less_big.php
real    0m0.330s
user    0m0.206s
sys     0m0.121s

$ time ./php+ /tmp/less_big.php
real    0m0.333s
user    0m0.207s
sys     0m0.124s


=== TEST 3 ===
$ time ./php+ /tmp/lots_null.php
real    0m0.263s
user    0m0.229s
sys     0m0.032s

$ time ./php+ /tmp/lots_null.php
real    0m0.261s
user    0m0.227s
sys     0m0.032s

$ time ./php+ /tmp/lots_null.php
real    0m0.260s
user    0m0.226s
sys     0m0.032s

$ time ./php+ /tmp/no_null.php
real    0m0.259s
user    0m0.226s
sys     0m0.032s

$ time ./php+ /tmp/no_null.php
real    0m0.257s
user    0m0.223s
sys     0m0.031s

$ time ./php+ /tmp/no_null.php
real    0m0.264s
user    0m0.229s
sys     0m0.032s

=== SCRIPTS ===
less_big.php
<?php

$str = str_repeat(str_repeat('foo', 1000).',', 11345);
$arr = explode(',', $str);

$out = implode(',', $arr);

lots_null.php
<?php

$str = str_repeat('foo,,', 99999);
$arr = explode(',', $str);

$out = implode(',', $arr);

more_small.php
<?php

$str = str_repeat('foo,bar,', 99999);
$arr = explode(',', $str);

$out = implode(',', $arr);

no_null.php
<?php

$str = str_repeat('foo,,', 99999);
$arr = explode(',', $str);

$out = implode(',', $arr, true);

------=_Part_25571_12489736.1228530081694
Content-Type: text/x-diff; name=implode.patch
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fodm5p150
Content-Disposition: attachment; filename=implode.patch

SW5kZXg6IGV4dC9zdGFuZGFyZC9waHBfc3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Jl
cG9zaXRvcnkvcGhwLXNyYy9leHQvc3RhbmRhcmQvcGhwX3N0cmluZy5oLHYKcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjg3LjIuMi4yLjMuMi4zCmRpZmYgLXUgLXIxLjg3LjIuMi4yLjMuMi4zIHBocF9z
dHJpbmcuaAotLS0gZXh0L3N0YW5kYXJkL3BocF9zdHJpbmcuaAkyIE5vdiAyMDA4IDE4OjI0OjM0
IC0wMDAwCTEuODcuMi4yLjIuMy4yLjMKKysrIGV4dC9zdGFuZGFyZC9waHBfc3RyaW5nLmgJNiBE
ZWMgMjAwOCAwMTo1Mjo0MiAtMDAwMApAQCAtMTM3LDcgKzEzNyw3IEBACiBQSFBBUEkgc2l6ZV90
IHBocF9zdHJpcF90YWdzX2V4KGNoYXIgKnJidWYsIGludCBsZW4sIGludCAqc3RhdGVwdHIsIGNo
YXIgKmFsbG93LCBpbnQgYWxsb3dfbGVuLCB6ZW5kX2Jvb2wgYWxsb3dfdGFnX3NwYWNlcyk7CiBQ
SFBBUEkgaW50IHBocF9jaGFyX3RvX3N0cl9leChjaGFyICpzdHIsIHVpbnQgbGVuLCBjaGFyIGZy
b20sIGNoYXIgKnRvLCBpbnQgdG9fbGVuLCB6dmFsICpyZXN1bHQsIGludCBjYXNlX3NlbnNpdGl2
aXR5LCBpbnQgKnJlcGxhY2VfY291bnQpOwogUEhQQVBJIGludCBwaHBfY2hhcl90b19zdHIoY2hh
ciAqc3RyLCB1aW50IGxlbiwgY2hhciBmcm9tLCBjaGFyICp0bywgaW50IHRvX2xlbiwgenZhbCAq
cmVzdWx0KTsKLVBIUEFQSSB2b2lkIHBocF9pbXBsb2RlKHp2YWwgKmRlbGltLCB6dmFsICphcnIs
IHp2YWwgKnJldHVybl92YWx1ZSBUU1JNTFNfREMpOworUEhQQVBJIHZvaWQgcGhwX2ltcGxvZGUo
enZhbCAqZGVsaW0sIHp2YWwgKmFyciwgenZhbCAqc2tpcF9lbXB0eSwgenZhbCAqcmV0dXJuX3Zh
bHVlIFRTUk1MU19EQyk7CiBQSFBBUEkgdm9pZCBwaHBfZXhwbG9kZSh6dmFsICpkZWxpbSwgenZh
bCAqc3RyLCB6dmFsICpyZXR1cm5fdmFsdWUsIGludCBsaW1pdCk7CiAKIFBIUEFQSSBzaXplX3Qg
cGhwX3N0cnNwbihjaGFyICpzMSwgY2hhciAqczIsIGNoYXIgKnMxX2VuZCwgY2hhciAqczJfZW5k
KTsgCkluZGV4OiBleHQvc3RhbmRhcmQvc3RyaW5nLmMKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Jl
cG9zaXRvcnkvcGhwLXNyYy9leHQvc3RhbmRhcmQvc3RyaW5nLmMsdgpyZXRyaWV2aW5nIHJldmlz
aW9uIDEuNDQ1LjIuMTQuMi42OS4yLjM4CmRpZmYgLXUgLXIxLjQ0NS4yLjE0LjIuNjkuMi4zOCBz
dHJpbmcuYwotLS0gZXh0L3N0YW5kYXJkL3N0cmluZy5jCTIxIE5vdiAyMDA4IDE5OjE2OjUwIC0w
MDAwCTEuNDQ1LjIuMTQuMi42OS4yLjM4CisrKyBleHQvc3RhbmRhcmQvc3RyaW5nLmMJNiBEZWMg
MjAwOCAwMTo1Mjo0NCAtMDAwMApAQCAtMTAzMywzMCArMTAzMywyOCBAQAogfQogLyogfX19ICov
CiAKLS8qIHt7eyBwcm90byBzdHJpbmcgam9pbihhcnJheSBzcmMsIHN0cmluZyBnbHVlKQorLyog
e3t7IHByb3RvIHN0cmluZyBqb2luKGFycmF5IHNyYywgc3RyaW5nIGdsdWVbLCBib29sZWFuIHNr
aXBfZW1wdHldKQogICAgQW4gYWxpYXMgZm9yIGltcGxvZGUgKi8KIC8qIH19fSAqLwogCiAvKiB7
e3sgcGhwX2ltcGxvZGUKICAqLwotUEhQQVBJIHZvaWQgcGhwX2ltcGxvZGUoenZhbCAqZGVsaW0s
IHp2YWwgKmFyciwgenZhbCAqcmV0dXJuX3ZhbHVlIFRTUk1MU19EQykgCitQSFBBUEkgdm9pZCBw
aHBfaW1wbG9kZSh6dmFsICpkZWxpbSwgenZhbCAqYXJyLCB6dmFsICpza2lwX2VtcHR5LCB6dmFs
ICpyZXR1cm5fdmFsdWUgVFNSTUxTX0RDKSAKIHsKIAl6dmFsICAgICAgICAgKip0bXA7CiAJSGFz
aFBvc2l0aW9uICAgcG9zOwogCXNtYXJ0X3N0ciAgICAgIGltcGxzdHIgPSB7MH07Ci0JaW50ICAg
ICAgICAgICAgbnVtZWxlbXMsIGkgPSAwOwotCXp2YWwgdG1wX3ZhbDsKLQlpbnQgc3RyX2xlbjsK
LQotCW51bWVsZW1zID0gemVuZF9oYXNoX251bV9lbGVtZW50cyhaX0FSUlZBTF9QKGFycikpOwor
CXp2YWwgICAgICAgICAgIHRtcF92YWw7CisJaW50ICAgICAgICAgICAgc3RyX2xlbiwgbGVuOwog
Ci0JaWYgKG51bWVsZW1zID09IDApIHsKKwlpZiAoemVuZF9oYXNoX251bV9lbGVtZW50cyhaX0FS
UlZBTF9QKGFycikpID09IDApIHsKIAkJUkVUVVJOX0VNUFRZX1NUUklORygpOwogCX0KIAogCXpl
bmRfaGFzaF9pbnRlcm5hbF9wb2ludGVyX3Jlc2V0X2V4KFpfQVJSVkFMX1AoYXJyKSwgJnBvcyk7
CiAKIAl3aGlsZSAoemVuZF9oYXNoX2dldF9jdXJyZW50X2RhdGFfZXgoWl9BUlJWQUxfUChhcnIp
LCAodm9pZCAqKikgJnRtcCwgJnBvcykgPT0gU1VDQ0VTUykgeworICAgICAgICBsZW4gPSBpbXBs
c3RyLmxlbjsKIAkJc3dpdGNoICgoKnRtcCktPnR5cGUpIHsKIAkJCWNhc2UgSVNfU1RSSU5HOgog
CQkJCXNtYXJ0X3N0cl9hcHBlbmRsKCZpbXBsc3RyLCBaX1NUUlZBTF9QUCh0bXApLCBaX1NUUkxF
Tl9QUCh0bXApKTsKQEAgLTExMDcsMTEgKzExMDUsMTUgQEAKIAkJCQkKIAkJfQogCi0JCWlmICgr
K2kgIT0gbnVtZWxlbXMpIHsKLQkJCXNtYXJ0X3N0cl9hcHBlbmRsKCZpbXBsc3RyLCBaX1NUUlZB
TF9QKGRlbGltKSwgWl9TVFJMRU5fUChkZWxpbSkpOwotCQl9CiAJCXplbmRfaGFzaF9tb3ZlX2Zv
cndhcmRfZXgoWl9BUlJWQUxfUChhcnIpLCAmcG9zKTsKKwkJaWYgKFpfQlZBTF9QKHNraXBfZW1w
dHkpICYmIChpbXBsc3RyLmxlbiA9PSBsZW4pKSB7CisJCQljb250aW51ZTsKKwkJfQorICAgICAg
ICBzbWFydF9zdHJfYXBwZW5kbCgmaW1wbHN0ciwgWl9TVFJWQUxfUChkZWxpbSksIFpfU1RSTEVO
X1AoZGVsaW0pKTsKIAl9CisgICAgaWYgKGltcGxzdHIubGVuKSB7CisgICAgICAgIGltcGxzdHIu
bGVuLS07CisgICAgfQogCXNtYXJ0X3N0cl8wKCZpbXBsc3RyKTsKIAogCWlmIChpbXBsc3RyLmxl
bikgewpAQCAtMTEyMywxNCArMTEyNSwxNCBAQAogfQogLyogfX19ICovCiAKLS8qIHt7eyBwcm90
byBzdHJpbmcgaW1wbG9kZShbc3RyaW5nIGdsdWUsXSBhcnJheSBwaWVjZXMpCisvKiB7e3sgcHJv
dG8gc3RyaW5nIGltcGxvZGUoW3N0cmluZyBnbHVlLF0gYXJyYXkgcGllY2VzWywgYm9vbGVhbiBz
a2lwX2VtcHR5XSkKICAgIEpvaW5zIGFycmF5IGVsZW1lbnRzIHBsYWNpbmcgZ2x1ZSBzdHJpbmcg
YmV0d2VlbiBpdGVtcyBhbmQgcmV0dXJuIG9uZSBzdHJpbmcgKi8KIFBIUF9GVU5DVElPTihpbXBs
b2RlKQogewotCXp2YWwgKiphcmcxID0gTlVMTCwgKiphcmcyID0gTlVMTCwgKmRlbGltLCAqYXJy
OworCXp2YWwgKiphcmcxID0gTlVMTCwgKiphcmcyID0gTlVMTCwgKiphcmczID0gTlVMTCwgKmRl
bGltLCAqYXJyLCAqc2tpcF9lbXB0eTsKIAlIYXNoUG9zaXRpb24gcG9zOwogCi0JaWYgKHplbmRf
cGFyc2VfcGFyYW1ldGVycyhaRU5EX05VTV9BUkdTKCkgVFNSTUxTX0NDLCAiWnxaIiwgJmFyZzEs
ICZhcmcyKSA9PSBGQUlMVVJFKSB7CisJaWYgKHplbmRfcGFyc2VfcGFyYW1ldGVycyhaRU5EX05V
TV9BUkdTKCkgVFNSTUxTX0NDLCAiWnxaWiIsICZhcmcxLCAmYXJnMiwgJmFyZzMpID09IEZBSUxV
UkUpIHsKIAkJcmV0dXJuOwogCX0KIAkKQEAgLTExNjEsOSArMTE2MywxNyBAQAogCQl9CiAJfQog
CisJaWYgKGFyZzMgIT0gTlVMTCkgeworCQljb252ZXJ0X3RvX2Jvb2xlYW5fZXgoYXJnMyk7CisJ
CXNraXBfZW1wdHkgPSAqYXJnMzsKKwl9IGVsc2UgeworCQlNQUtFX1NURF9aVkFMKHNraXBfZW1w
dHkpOworCQlaVkFMX0JPT0woc2tpcF9lbXB0eSwgMCk7CisJfQorCiAJcG9zID0gWl9BUlJWQUxf
UChhcnIpLT5wSW50ZXJuYWxQb2ludGVyOwogCQotCXBocF9pbXBsb2RlKGRlbGltLCBhcnIsIHJl
dHVybl92YWx1ZSBUU1JNTFNfQ0MpOworCXBocF9pbXBsb2RlKGRlbGltLCBhcnIsIHNraXBfZW1w
dHksIHJldHVybl92YWx1ZSBUU1JNTFNfQ0MpOwogCiAJWl9BUlJWQUxfUChhcnIpLT5wSW50ZXJu
YWxQb2ludGVyID0gcG9zOwogCkluZGV4OiB0ZXN0cy9zdHJpbmdzLzAwMS5waHB0Cj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KUkNTIGZpbGU6IC9yZXBvc2l0b3J5L3BocC1zcmMvdGVzdHMvc3RyaW5ncy8wMDEucGhwdCx2
CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zLjQuMS40LjEKZGlmZiAtdSAtcjEuMy40LjEuNC4xIDAw
MS5waHB0Ci0tLSB0ZXN0cy9zdHJpbmdzLzAwMS5waHB0CTUgSnVuIDIwMDggMDg6Mjk6MjkgLTAw
MDAJMS4zLjQuMS40LjEKKysrIHRlc3RzL3N0cmluZ3MvMDAxLnBocHQJNiBEZWMgMjAwOCAwMTo1
Mjo0OSAtMDAwMApAQCAtMTkwLDYgKzE5MCwxOCBAQAogCWVjaG8oImZhaWxlZCFcbiIpOwogfQog
CitlY2hvICdUZXN0aW5nIGltcGxvZGU6ICc7CiskZm9vID0gJ2Jhcic7CiskYXJyID0gYXJyYXko
MSwnJywyLG51bGwsMywwLDQsdHJ1ZSw1LGZhbHNlLGZhbHNlKTsKKworJHN0cjEgPSBpbXBsb2Rl
KCcsJywgJGFycik7Ciskc3RyMiA9IGltcGxvZGUoJywnLCAkYXJyLCAkZm9vKTsKKworaWYgKCRz
dHIxID09ICcxLCwyLCwzLDAsNCwxLDUsLCcgJiYgJHN0cjIgPT0gJzEsMiwzLDAsNCwxLDUnICYm
ICRmb28gPT0gJ2JhcicpIHsKKwllY2hvKCJwYXNzZWRcbiIpOworfSBlbHNlIHsKKwllY2hvKCJm
YWlsZWQhXG4iKTsKK30KID8+CiAtLUVYUEVDVC0tCiBUZXN0aW5nIHN0cnRvazogcGFzc2VkCkBA
IC0yMDgsMyArMjIwLDUgQEAKIFRlc3RpbmcgYWRkc2xhc2hlczogcGFzc2VkCiBUZXN0aW5nIHN0
cmlwc2xhc2hlczogcGFzc2VkCiBUZXN0aW5nIHVuaXFpZDogcGFzc2VkCitUZXN0aW5nIGltcGxv
ZGU6IHBhc3NlZAorCg==
------=_Part_25571_12489736.1228530081694--