Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42082 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82803 invoked from network); 29 Nov 2008 15:30:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Nov 2008 15:30:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=php-php-dev@m.gmane.org; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=news@ger.gmane.org; sender-id=pass Received-SPF: pass (pb1.pair.com: domain m.gmane.org designates 80.91.229.2 as permitted sender) X-PHP-List-Original-Sender: php-php-dev@m.gmane.org X-Host-Fingerprint: 80.91.229.2 main.gmane.org Linux 2.5 (sometimes 2.4) (4) Received: from [80.91.229.2] ([80.91.229.2:54533] helo=ciao.gmane.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6C/76-30340-23061394 for ; Sat, 29 Nov 2008 10:30:59 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L6RmU-0005S2-5q for internals@lists.php.net; Sat, 29 Nov 2008 15:30:50 +0000 Received: from p5b3760f9.dip.t-dialin.net ([91.55.96.249]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 29 Nov 2008 15:30:50 +0000 Received: from sb by p5b3760f9.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 29 Nov 2008 15:30:50 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: internals@lists.php.net Date: Sat, 29 Nov 2008 16:30:34 +0100 Lines: 14 Message-ID: References: <491B2E81.3070601@sebastian-bergmann.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: p5b3760f9.dip.t-dialin.net User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) In-Reply-To: Sender: news Subject: Re: [PHP-DEV] ReflectionProperty::setValue() and ReflectionProperty::setAccessible() From: sb@sebastian-bergmann.de (Sebastian Bergmann) Derick Rethans schrieb: > We shouldn't really modify test cases though, but just add new ones. I only modified the existing test case because it contained dead code and looked a bit confusing to me when I first read it. > Other than that it looks ok, and yes, I simply forgot about this when > adding this. Thanks! -- Sebastian Bergmann http://sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69