Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:42081 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80975 invoked from network); 29 Nov 2008 15:19:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Nov 2008 15:19:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.94.239.7 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.94.239.7 mail.jdi-ict.nl Linux 2.6 Received: from [82.94.239.7] ([82.94.239.7:57949] helo=mail.jdi-ict.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A8/26-30340-79D51394 for ; Sat, 29 Nov 2008 10:19:52 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id mATFJlrQ018230; Sat, 29 Nov 2008 16:19:47 +0100 Date: Sat, 29 Nov 2008 16:19:48 +0100 (CET) X-X-Sender: derick@kossu.ez.no To: Sebastian Bergmann cc: internals@lists.php.net In-Reply-To: Message-ID: References: <491B2E81.3070601@sebastian-bergmann.de> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] ReflectionProperty::setValue() and ReflectionProperty::setAccessible() From: derick@php.net (Derick Rethans) On Sat, 29 Nov 2008, Sebastian Bergmann wrote: > Sebastian Bergmann schrieb: > > Currently ReflectionProperty::setValue() ignores the setting made by > > ReflectionProperty::setAccessible(). Is this intentional or was it just > > forgotten to handle ref->ignore_visibility in setValue()? > > See http://bugs.php.net/bug.php?id=46718 for a patch that implements the > missing functionality in ReflectionProperty::setValue(). We shouldn't really modify test cases though, but just add new ones. Other than that it looks ok, and yes, I simply forgot about this when adding this. Derick -- HEAD before 5_3!: http://tinyurl.com/6d2esb http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org