Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41998 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14930 invoked from network); 19 Nov 2008 13:36:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Nov 2008 13:36:46 -0000 Authentication-Results: pb1.pair.com header.from=tobias@schlitt.info; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=tobias@schlitt.info; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlitt.info from 85.214.110.30 cause and error) X-PHP-List-Original-Sender: tobias@schlitt.info X-Host-Fingerprint: 85.214.110.30 hartes-php.de Linux 2.6 Received: from [85.214.110.30] ([85.214.110.30:59310] helo=hartes-php.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F1/08-06451-C6614294 for ; Wed, 19 Nov 2008 08:36:45 -0500 Received: (qmail 20489 invoked from network); 19 Nov 2008 13:36:41 -0000 Received: from vpn0208.hrz.uni-dortmund.de (HELO ?129.217.154.208?) (tobias@schlitt.info@129.217.154.208) by hartes-php.de with ESMTPA; 19 Nov 2008 13:36:41 -0000 Message-ID: <49241664.2070904@schlitt.info> Date: Wed, 19 Nov 2008 14:36:36 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041124 Thunderbird/0.9 Mnenhy/0.6.0.104 MIME-Version: 1.0 To: David Coallier CC: internals@lists.php.net References: <4923E926.8050901@schlitt.info> In-Reply-To: X-Enigmail-Version: 0.95.7 OpenPGP: id=C462BC14 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] SplHeap->key() From: tobias@schlitt.info (Tobias Schlitt) Hi, On 11/19/2008 11:38 AM David Coallier wrote: >> I noticed that SplHeap returns the current element count of the heap >> from key(). I think it should return count - 1 to reflect 0 indexing. >> key won't be called outside of an iterator, so this makes sense. > I'd say this is a bug as well, would you mind opening a bug and > assigning it to me please? Done. Cheers, Toby -- Tobias Schlitt - Zend Certification Member GPG Key: 0xC462BC14 a passion for php http://www.schlitt.info Member of the eZ components project http://components.ez.no