Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41995 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74834 invoked from network); 19 Nov 2008 10:38:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Nov 2008 10:38:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=david.coallier@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=david.coallier@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.233 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: david.coallier@gmail.com X-Host-Fingerprint: 209.85.198.233 rv-out-0506.google.com Received: from [209.85.198.233] ([209.85.198.233:43260] helo=rv-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5C/60-06451-4BCE3294 for ; Wed, 19 Nov 2008 05:38:45 -0500 Received: by rv-out-0506.google.com with SMTP id g37so3445085rvb.23 for ; Wed, 19 Nov 2008 02:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=KBvEkVT9b7PpsuM26BotdT20tmeoF8oucEdKyW2tZ9o=; b=FYUESGuaa5b7jrvFYImUmP9sVVcGXF0LM0UdHSC9zSfmAi1qNNxkodwC67sSUvREhc s1oJTyqWgzZqxRDV0s9we9gpFfxYjB0+obXHWFuXPNb3cPyiaGOSHgQCYIJYb22kDnOx INu7Y56Fg2ky0k4dwcZcngM4l7WocJM2ciMjs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=nmSK+3G0ysnbXhGIhmALECs4JlBZzHVDWGvDkGFGILR3x8i72iyAj3rIvs20t3K+OP KYpEZJuZIF88D0oSCYfODZT1vPO2iV+2suJlA0YUxcWiUfQi2WjM0GRgub9u84zW7mD3 PF6Nm+DCSY7lvfYkYR6WcHikv0xtz9H6NRxHE= Received: by 10.142.162.5 with SMTP id k5mr457029wfe.287.1227091121879; Wed, 19 Nov 2008 02:38:41 -0800 (PST) Received: by 10.143.9.16 with HTTP; Wed, 19 Nov 2008 02:38:41 -0800 (PST) Message-ID: Date: Wed, 19 Nov 2008 10:38:41 +0000 Sender: david.coallier@gmail.com To: "Tobias Schlitt" Cc: internals@lists.php.net In-Reply-To: <4923E926.8050901@schlitt.info> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4923E926.8050901@schlitt.info> X-Google-Sender-Auth: 3add3afea38bd4ae Subject: Re: [PHP-DEV] SplHeap->key() From: davidc@php.net ("David Coallier") > > I noticed that SplHeap returns the current element count of the heap > from key(). I think it should return count - 1 to reflect 0 indexing. > key won't be called outside of an iterator, so this makes sense. > I'd say this is a bug as well, would you mind opening a bug and assigning it to me please? Etienne/Marcus, do you mind if I go ahead? -- Slan, David