Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41957
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.156 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=iB/l74u+SxqA1aZLAXMz7MW58t8UdseEsq4WH8hewKCMUQRPlcnBmhMignBFBf5pcG
         w1SIDAgBlCW0YEWh3nBPuspIyilVZJtR8mEfEmvTDdJWj28iOx9YVipkwrYye5U37wI7
         Q/VNSCYAn30yAl9D0YvDIxbU/BA9h4Kh7BjI8=
Message-ID: <2dedb8a0811170016i74ce2faepef092a1302920202@mail.gmail.com>
Date: Mon, 17 Nov 2008 09:16:13 +0100
To: "Christopher Vogt" <christopher.vogt@rwth-aachen.de>
Cc: internals@lists.php.net
In-Reply-To: <28.8E.39815.8C421294@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <28.8E.39815.8C421294@pb1.pair.com>
Subject: Re: [PHP-DEV] Fatal error: Call to a member function on a non-object
From: kalle.php@gmail.com ("Kalle Sommer Nielsen")

Hi

2008/11/17 Christopher Vogt <christopher.vogt@rwth-aachen.de>:
> Hej,
>
> I use PHP 5.2.6. I am refactoring some code to use more
> object-orientation. I encounter a problem, where the new object-oriented
> version results in a fatal error, where the old array-oriented version
> didn't.
>
> I fetch records a database. Sometime it happens that a record does not
> exist anymore. Let's assume it's a user, then $user will be NULL.
>
> echo $user['fullname']; // no error at all, $user['fullname'] === NULL
>
> Shouldn't this at least trigger a Notice?
>
> echo $user->get_fullname(); // Fatal error
>
> I agree this should trigger an error, but a "Fatal error" is a little
> too much, I think. It terminates the script leaving the html-document
> incomplete. I would prefer a "Warning" and NULL instead.
>
> Is there any reason against it?

I personally don't really mind it, as you got the instanceof and
typehinting to check for whenever a variable is an object, so I would
say its more of a user design issue. Fatal errors just requires you to
refactor your code so your code shouldn't emit such things which I'm
alright with.

>
> Best regards
>
> Christopher
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Kalle Sommer Nielsen