Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41893
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.155 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id:sender;
        b=lQSwCJ7AkP/h1THBy1986SHUQDvfsNuELpCx98FEFi9k8fLUHXc24RI2lWq5p3ZEI3
         D2arLFV7DL5UJg72VVZZVIwwxfXsZAERbtj0vflSmkyOODV65IV55K3Pgx9QrZEXISNT
         Bij8Aas0YJjjluVOcsm4AHlbf9cbQ++wZZ8oc=
To: "Uwe Schindler" <thetaphi@php.net>
Date: Thu, 13 Nov 2008 14:48:30 +0100
User-Agent: KMail/1.10.3 (Linux/2.6.26-1-amd64; KDE/4.1.3; x86_64; ; )
Cc: internals@lists.php.net,
 "'Christian Schmidt'" <chsc@peytz.dk>,
 Alex Leigh <aleigh@php.net>,
 George Wang <gwang@php.net>
References: <48FBA987.5030809@peytz.dk> <200811092201.36508.lbarnaud@php.net> <841365F95ED5461292599AE9813EA9FA@VEGA>
In-Reply-To: <841365F95ED5461292599AE9813EA9FA@VEGA>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200811131448.31004.lbarnaud@php.net>
Sender: Arnaud LB <arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
From: lbarnaud@php.net (Arnaud Le Blanc)

Hi,

Committed, thanks Christian :)

apache2handler, apache2filter, apache, apache_hooks, cli and cgi SAPIs have 
been updated.

The following SAPIs need to be updated in PHP_5_3 and HEAD:
aolserver, continuity, litespeed, nsapi, caudium, phttpd, roxen. (I'm CC-ing 
known maintainers)

More informations on the change can be found in the commit message:
http://news.php.net/php.cvs/54228

Regards,

Arnaud

On Sunday 09 November 2008 22:49:47 Uwe Schindler wrote:
> +1
> 
> I have no problem with implementing this for NSAPI after the patch is
> committed to CVS, just keep me informed about this.
> 
> -----
> Uwe Schindler
> thetaphi@php.net - http://www.php.net
> NSAPI SAPI developer
> Bremen, Germany
> 
> > -----Original Message-----
> > From: Arnaud LB [mailto:arnaud.lb@gmail.com] On Behalf Of Arnaud Le Blanc
> > Sent: Sunday, November 09, 2008 10:02 PM
> > To: internals@lists.php.net
> > Cc: Christian Schmidt
> > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set
> > usingheader()
> > 
> > On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote:
> > > Stan Vassilev | FM wrote:
> > > > I suggest header_remove('*') or simply header_remove() /no param/
> > > > removes all headers (including the one PHP sets by default), so we can
> > > > start with a clear state.
> > >
> > > I added header_remove('Foo'). header_remove() without arguments removes
> > > all headers (though Apache still adds some headers that you cannot
> > remove).
> > >
> > > I have tested with apache2handler and cgi. I had to change the signature
> > > of SAPI header_handler function and sapi_header_struct, so the other
> > > SAPIs should be updated for this. I am not sure how to test all these?
> > > Creating a testing environment for all those webservers seems like a
> > > huge task.
> > >
> > > I am not comfortable with the size of this patch, given my understanding
> > > of the PHP source code and my general C skills, so I am posting this
> > > patch hoping that somebody will pick it up or help me get it into shape.
> > >
> > 
> > It looks good. The signature change is not that bad if it forces all SAPIs
> > to
> > be updated and ensures that PHP behaves the same way with all SAPIs.
> > 
> > It is also possible to add something like header_delete_handler() or
> > header_handler_ex() to sapi_module_struct if the signature change is to be
> > avoided.
> > 
> > Regards,
> > 
> > Arnaud
> > 
> > 
> > 
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> 
> 
>