Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41857
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.132.251 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references:x-google-sender-auth;
        b=p9gL0srpvzeAgndvtdIvmpNxdEy9jiYxceTf6vATmXdkHJA2bMPAQ2iiAZVTE9jJjF
         29euxgGDevc6g4iWFHsEOOiJKKlbzzVWeWivhdXkdRUZ0LU6KezNoySa0DQvwa0vU25C
         Q4CK7a3SJDkNczH60RQSRnkD4JBnsXnq4ww0k=
Message-ID: <e666c3890811111400v69a2267t6844fd8add934167@mail.gmail.com>
Date: Tue, 11 Nov 2008 23:00:34 +0100
Sender: ekneuss@gmail.com
To: "David Grudl" <david@grudl.com>
Cc: "PHP internals" <internals@lists.php.net>, 
	marcus.boerger@post.rwth-aachen.de
In-Reply-To: <4919AFE5.5000203@grudl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4919AFE5.5000203@grudl.com>
Subject: Re: [PHP-DEV] New SPL exceptions proposal
From: colder@php.net ("Etienne Kneuss")

Hello David,

On Tue, Nov 11, 2008 at 5:16 PM, David Grudl <david@grudl.com> wrote:
> Hello *internals* and Marcus!
>
> What do you think about possibility to implement to PHP 5.3 several useful
> default exceptions?
>
> (note that InvalidArgumentException, RuntimeException and LogicException
> exists since PHP 5.1)
>
> /**
> * The exception that is thrown when the value of an argument is
> * outside the allowable range of values as defined by the invoked method.
> */
> class ArgumentOutOfRangeException extends InvalidArgumentException
> {}

Looks a bit redundant with OutOfRangeException

>
> /**
> * The exception that is thrown when a method call is invalid for the
> object's
> * current state, method has been invoked at an illegal or inappropriate
> time.
> */
> class InvalidStateException extends RuntimeException
> {}
>
> /**
> * The exception that is thrown when a requested method or operation is not
> implemented.
> */
> class NotImplementedException extends LogicException
> {}
>
> /**
> * The exception that is thrown when a requested method or operation is
> deprecated.
> */
> class DeprecatedException extends LogicException
> {}
>
> /**
> * The exception that is thrown when an invoked method is not supported. For
> scenarios where
> * it is sometimes possible to perform the requested operation, see
> InvalidStateException.
> */
> class NotSupportedException extends LogicException
> {}
>
> /**
> * The exception that is thrown when an I/O error occurs.
> */
> class IOException extends RuntimeException
> {}
>
> /**
> * The exception that is thrown when accessing a file that does not exist on
> disk.
> */
> class FileNotFoundException extends IOException
> {}
>
> /**
> * The exception that is thrown when part of a file or directory cannot be
> found.
> */
> class DirectoryNotFoundException extends IOException
> {}
>
>
> And the last one (this is something like BadMethodException, but for
> properties)
>
> /**
> * The exception that is thrown when accessing a class member (property or
> method) fails.
> */
> class MemberAccessException extends LogicException
> {}
>

The main problem about adding such classes is that it may/will break
BC, so for one they will have to be renamed Spl*Exception.
Additionally, there is little point in defining these exceptions if we
don't use them internally, and afaik SPL wouldn't need all of them.
On the other hand, we still have lot or generic RuntimeExceptions [1],
we might want to use more specific classes for them but I believe the
currently available exceptions will suffice in most cases.

Regards


1:
colder@larry ~/cvs/php-src $ fgrep -r "zend_throw_exception"
ext/spl/*.c | php -R 'preg_match("/spl_ce_(\w+)/", $argn, $match);
echo $match[1]."\n";' | sort | uniq -c
     12 BadMethodCallException
      1 DomainException
     17 InvalidArgumentException
     12 LogicException
      3 OutOfBoundsException
     10 OutOfRangeException
     40 RuntimeException
      7 UnexpectedValueException

>
> David Grudl
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>



-- 
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal