Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41787
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 80.190.230.99 as permitted sender)
To: "'Arnaud Le Blanc'" <lbarnaud@php.net>,
	<internals@lists.php.net>
Cc: "'Christian Schmidt'" <chsc@peytz.dk>
References: <48FBA987.5030809@peytz.dk> <42FD82032C7D484CAC254FC5D6C292E1@pc> <49173133.4040104@peytz.dk> <200811092201.36508.lbarnaud@php.net>
Date: Sun, 9 Nov 2008 22:49:47 +0100
Message-ID: <841365F95ED5461292599AE9813EA9FA@VEGA>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <200811092201.36508.lbarnaud@php.net>
Thread-Index: AclCrnWCd+ErKIjdQjyP8OO+Tqd2xAABnibQ
Subject: RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
From: thetaphi@php.net ("Uwe Schindler")

+1

I have no problem with implementing this for NSAPI after the patch is
committed to CVS, just keep me informed about this.

-----
Uwe Schindler
thetaphi@php.net - http://www.php.net
NSAPI SAPI developer
Bremen, Germany

> -----Original Message-----
> From: Arnaud LB [mailto:arnaud.lb@gmail.com] On Behalf Of Arnaud Le Blanc
> Sent: Sunday, November 09, 2008 10:02 PM
> To: internals@lists.php.net
> Cc: Christian Schmidt
> Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set
> usingheader()
> 
> On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote:
> > Stan Vassilev | FM wrote:
> > > I suggest header_remove('*') or simply header_remove() /no param/
> > > removes all headers (including the one PHP sets by default), so we can
> > > start with a clear state.
> >
> > I added header_remove('Foo'). header_remove() without arguments removes
> > all headers (though Apache still adds some headers that you cannot
> remove).
> >
> > I have tested with apache2handler and cgi. I had to change the signature
> > of SAPI header_handler function and sapi_header_struct, so the other
> > SAPIs should be updated for this. I am not sure how to test all these?
> > Creating a testing environment for all those webservers seems like a
> > huge task.
> >
> > I am not comfortable with the size of this patch, given my understanding
> > of the PHP source code and my general C skills, so I am posting this
> > patch hoping that somebody will pick it up or help me get it into shape.
> >
> 
> It looks good. The signature change is not that bad if it forces all SAPIs
> to
> be updated and ensures that PHP behaves the same way with all SAPIs.
> 
> It is also possible to add something like header_delete_handler() or
> header_handler_ex() to sapi_module_struct if the signature change is to be
> avoided.
> 
> Regards,
> 
> Arnaud
> 
> 
> 
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php