Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41785
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.154 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id:sender;
        b=rYbKUZoe4lam0DYbLaWfF0LbFBakc/klKr5nWVd1PNDMKbGxaBnicL+bAbdowyDm82
         3/ZAglxHseFTstAA3h3hMfOog1PtRAMEc4iezTBIKIqE4A8COggZjn3yowLZ8spiHKcH
         c6voZFqrLXWrm7y+qrSp1l+SQd/33kTJUQLWg=
To: internals@lists.php.net
Date: Sun, 9 Nov 2008 22:01:36 +0100
User-Agent: KMail/1.10.3 (Linux/2.6.26-1-amd64; KDE/4.1.3; x86_64; ; )
Cc: Christian Schmidt <chsc@peytz.dk>
References: <48FBA987.5030809@peytz.dk> <42FD82032C7D484CAC254FC5D6C292E1@pc> <49173133.4040104@peytz.dk>
In-Reply-To: <49173133.4040104@peytz.dk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200811092201.36508.lbarnaud@php.net>
Sender: Arnaud LB <arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()
From: lbarnaud@php.net (Arnaud Le Blanc)

On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote:
> Stan Vassilev | FM wrote:
> > I suggest header_remove('*') or simply header_remove() /no param/ 
> > removes all headers (including the one PHP sets by default), so we can 
> > start with a clear state.
> 
> I added header_remove('Foo'). header_remove() without arguments removes 
> all headers (though Apache still adds some headers that you cannot remove).
> 
> I have tested with apache2handler and cgi. I had to change the signature 
> of SAPI header_handler function and sapi_header_struct, so the other 
> SAPIs should be updated for this. I am not sure how to test all these? 
> Creating a testing environment for all those webservers seems like a 
> huge task.
> 
> I am not comfortable with the size of this patch, given my understanding 
> of the PHP source code and my general C skills, so I am posting this 
> patch hoping that somebody will pick it up or help me get it into shape.
> 

It looks good. The signature change is not that bad if it forces all SAPIs to 
be updated and ensures that PHP behaves the same way with all SAPIs.

It is also possible to add something like header_delete_handler() or 
header_handler_ex() to sapi_module_struct if the signature change is to be 
avoided.

Regards,

Arnaud