Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41755
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.46.29 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=cZ4ppW3ke5ubuFLBbodiHWwe9EmU81AhnYJ1DrU9Ds+74JyIYWwYi+AHZVbc4krNyu
         06HPfCS3AkcEkgoqEEwJG+8z7OcxRWE4hA3oW8TIRGNsUTYTFkCEdxPsPCdzPUeB25YL
         KqQ8Oy0OytL3NLuudR3Yt3Muk6qZG2af1InrY=
Message-ID: <fe05d1540811070057s2655f724mdaebd966c9fbb14b@mail.gmail.com>
Date: Fri, 7 Nov 2008 09:57:06 +0100
To: "Lukas Kahwe Smith" <mls@pooteeweet.org>
Cc: "Hannes Magnusson" <hannes.magnusson@gmail.com>, 
	"PHP Development" <internals@lists.php.net>
In-Reply-To: <5363D8C5-B060-48E1-B626-D7BCA3BBD1C2@pooteeweet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <78F3CCDA-D0E5-4B13-88B1-72CB0D442A46@pooteeweet.org>
	 <7f3ed2c30811070029v23715e61j2310c39d3e3e9366@mail.gmail.com>
	 <fe05d1540811070030u3d6cb9efuf046af2ba934a11c@mail.gmail.com>
	 <5363D8C5-B060-48E1-B626-D7BCA3BBD1C2@pooteeweet.org>
Subject: Re: [PHP-DEV] alpha3
From: pierre.php@gmail.com ("Pierre Joye")

hi,

On Fri, Nov 7, 2008 at 9:51 AM, Lukas Kahwe Smith <mls@pooteeweet.org> wrote:

> To quote myself on this topic:
> "These are all convincing arguments to have done this earlier. But Johannes
> and I are a bit worried, that this code did not see that much testing since
> it was checked in to HEAD quite a while ago. And seeing that the backport is
> mainly cleanup and not bug fixing, we are a bit worried about the risk this
> backport has (not necessarily in it introducing bugs, but more about BC
> issues here and there). Especially since it seems that you are the only one
> who actively looks after output buffering .. (Johannes actually asked to
> have this stuff in PHP 5.3 months ago, but you were a  bit MIA back then ..
> and nobody else showed interest).
>
> So unless you can take our worries away in terms of BC issues, I guess we
> would prefer to leave this patch out of PHP 5.3.
> Sorry about the misunderstanding and the work you put into producing this
> patch."

It is why alpha releases are for. If we don't merge it we should
simply drop it in HEAD and forget it. This code has been there for
years now, it is time to bring it to a stable branch. The same applies
for other code in HEAD not having merged to 5.3.


Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org