Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41718
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.162.182 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=ewupCH7SorVUBU9RCU6a33ofIDycBhGoGdnvdw944gqCn40oPg8XfoufDbG7wguOsU
         OgPQpcOiaH729QZLSBJqFxFcpc1HnxIVEKlseDvoB98X89AL6T99em2zCCghBg7tW5TM
         yDJvaufmR1xgxGAxuAxC9GcuQh4ncLGE9f5a0=
To: Geoffrey Sneddon <foolistbar@googlemail.com>
Cc: Stanislav Malyshev <stas@zend.com>, Lukas Kahwe Smith <mls@pooteeweet.org>,  PHP Internals <internals@lists.php.net>
In-Reply-To: <237D5067-10C6-4D25-8CCF-FEF9FE44F6F6@googlemail.com>
References: <4900DB81.4000805@zend.com> <4900E150.1010607@dynom.nl>
	 <49018FC3.90302@gmail.com>
	 <cd5680a20810240215t4d564ab6n4a397ff22166fa83@mail.gmail.com>
	 <1224854888.19390.89.camel@goldfinger.johannes.nop>
	 <490609A1.7090400@gravitonic.com> <1225199800.878.0.camel@localhost>
	 <3F3445975B55414BB4A214B32E178657@pc>
	 <4A4FE9BC-F000-4AEE-A68C-8EFEA9DCD154@pooteeweet.org>
	 <4910D3E5.4020406@zend.com>
	 <237D5067-10C6-4D25-8CCF-FEF9FE44F6F6@googlemail.com>
Content-Type: text/plain; charset=utf-8
Date: Thu, 06 Nov 2008 10:10:06 -0200
Message-ID: <1225973406.5465.18.camel@felipe>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] array_key_exists BC break
From: felipensp@gmail.com (Felipe Pena)

Hi all,

Em Qua, 2008-11-05 às 16:20 +0000, Geoffrey Sneddon escreveu:
> On 4 Nov 2008, at 22:59, Stanislav Malyshev wrote:
> 
> >> so where do we stand here?
> >
> > I'd prefer to have it fixed, but then it probably requires changing  
> > the parameters API for 'a', which might lead to some unexpected  
> > results with regard to functions that modify their arguments. I  
> > think we may leave it alone for this alpha but try to resolve it for  
> > 5.3 release.
> 
> If it isn't fixed it ought to be a documented as a BC break, seeming  
> it does break real apps.
> 
> 

So as suggested and wished, here is a patch that add a modifier '%' to
'a' in parameter parsing API, where it allows object that implements
ArrayAccess to be accept. Although it doesn't invoke any their methods,
i.e. just how it works nowdays.

A list of functions that allow object on current 5.2:
. end
. prev
. next
. reset
. current
. key
. array_key_exists
. array_unique
. array_flip
. array_walk_recursive
. array_walk
. uksort
. uasort
. usort
. natcasesort
. natsort

Hence, I added such modifier to this functions in the patch.

5.3: http://felipe.ath.cx/diff/arg_arrayaccess.diff

-- 
Regards,
Felipe Pena