Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41705
Return-Path: <greg@chiaraquartet.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 96995 invoked from network); 6 Nov 2008 04:36:43 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 6 Nov 2008 04:36:43 -0000
Authentication-Results: pb1.pair.com smtp.mail=greg@chiaraquartet.net; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=greg@chiaraquartet.net; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 74.125.44.30 cause and error)
X-PHP-List-Original-Sender: greg@chiaraquartet.net
X-Host-Fingerprint: 74.125.44.30 yx-out-2324.google.com  
Received: from [74.125.44.30] ([74.125.44.30:15074] helo=yx-out-2324.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 2C/E4-05635-A5472194 for <internals@lists.php.net>; Wed, 05 Nov 2008 23:36:43 -0500
Received: by yx-out-2324.google.com with SMTP id 3so181950yxj.83
        for <internals@lists.php.net>; Wed, 05 Nov 2008 20:36:39 -0800 (PST)
Received: by 10.64.143.4 with SMTP id q4mr1741020qbd.67.1225946199456;
        Wed, 05 Nov 2008 20:36:39 -0800 (PST)
Received: from ?192.168.0.106? ([76.84.4.101])
        by mx.google.com with ESMTPS id 25sm890846qbw.1.2008.11.05.20.36.37
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Wed, 05 Nov 2008 20:36:38 -0800 (PST)
Message-ID: <49127464.9080007@chiaraquartet.net>
Date: Wed, 05 Nov 2008 22:36:52 -0600
User-Agent: Thunderbird 2.0.0.17 (X11/20080925)
MIME-Version: 1.0
To: internals Mailing List <internals@lists.php.net>, 
 Stanislav Malyshev <stas@zend.com>,
 Marcus Boerger <helly@php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: fixing opcode modification in namespace implementation
From: greg@chiaraquartet.net (Gregory Beaver)

Hi,

I assigned this to helly arbitrarily, but wanted to make sure that Stas
and Dmitry also see it.  This should be fixed ASAP.  The opcode
modification was easy to fix, since we weren't using op1.  I also fixed
a cosmetic issue Dmitry wanted fixed, which was replacing the
non-verbose 1 and 2 used to identify namespace constant vs. namespace
function in zend_resolve_non_class_name() with #defines.

http://bugs.php.net/bug.php?id=46500
patch at http://pear.php.net/~greg/fix_ns1.patch.txt

Greg