Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41628
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Cc: "Jonah H. Harris" <jonah.harris@gmail.com>,
 internals@lists.php.net
Message-ID: <24192B59-D7C2-419C-8397-C22D638E7E60@pooteeweet.org>
To: Scott MacVicar <scott@macvicar.net>
In-Reply-To: <490F48F5.3090609@macvicar.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Date: Mon, 3 Nov 2008 20:15:14 +0100
References: <36e682920811031052x632ad22br35136b6fa45fe5f4@mail.gmail.com> <490F48F5.3090609@macvicar.net>
Subject: Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams()
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 03.11.2008, at 19:54, Scott MacVicar wrote:

> Jonah H. Harris wrote:
>> While using PDOStatement::debugDumpParams, I noticed that it results
>> in an endless loop because the hash table is not being traversed.  As
>> such, attached is a patch against php5 HEAD which adds
>> zend_hash_move_forward_ex accordingly.
>>
>>
>
> Your patch was stripped, can you attach against with a .txt extension.


interesting .. i wasnt aware of this method. there is a doc bug on  
this on pecl.php.net:
http://pecl.php.net/bugs/bug.php?id=13035

once again a reminder that we really do not have a good setup yet to  
manage the movement of extensions between pecl and php-src. also a  
pitty that the GSoC for a unified bug tracker apparently did not get  
finished (?)

regards,
Lukas Kahwe Smith
mls@pooteeweet.org