Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41627 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13698 invoked from network); 3 Nov 2008 18:54:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Nov 2008 18:54:57 -0000 Authentication-Results: pb1.pair.com header.from=scott@macvicar.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=scott@macvicar.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain macvicar.net from 193.227.246.108 cause and error) X-PHP-List-Original-Sender: scott@macvicar.net X-Host-Fingerprint: 193.227.246.108 ip246-108-v193.static.x-ip.net Received: from [193.227.246.108] ([193.227.246.108:44906] helo=lovelace.midden.org.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C4/C7-03485-0094F094 for ; Mon, 03 Nov 2008 13:54:56 -0500 Received: from office.vbulletin.com ([217.155.246.60] helo=[10.0.0.116]) by lovelace.midden.org.uk with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Kx4Ze-0007Fx-Vo; Mon, 03 Nov 2008 18:54:53 +0000 Message-ID: <490F48F5.3090609@macvicar.net> Date: Mon, 03 Nov 2008 18:54:45 +0000 User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: "Jonah H. Harris" CC: internals@lists.php.net References: <36e682920811031052x632ad22br35136b6fa45fe5f4@mail.gmail.com> In-Reply-To: <36e682920811031052x632ad22br35136b6fa45fe5f4@mail.gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Jonah H. Harris wrote: > While using PDOStatement::debugDumpParams, I noticed that it results > in an endless loop because the hash table is not being traversed. As > such, attached is a patch against php5 HEAD which adds > zend_hash_move_forward_ex accordingly. > > [...] Content analysis details: (-4.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.1 AWL AWL: From: address is in the auto white-list Subject: Re: [PHP-DEV] [PATCH]: Fix for endless loop in PDOStatement::debugDumpParams() From: scott@macvicar.net (Scott MacVicar) Jonah H. Harris wrote: > While using PDOStatement::debugDumpParams, I noticed that it results > in an endless loop because the hash table is not being traversed. As > such, attached is a patch against php5 HEAD which adds > zend_hash_move_forward_ex accordingly. > > Your patch was stripped, can you attach against with a .txt extension. Scott