Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41618 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57054 invoked from network); 2 Nov 2008 22:41:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Nov 2008 22:41:52 -0000 Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.186 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 64.233.182.186 nf-out-0910.google.com Received: from [64.233.182.186] ([64.233.182.186:41011] helo=nf-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A2/31-50864-EAC2E094 for ; Sun, 02 Nov 2008 17:41:51 -0500 Received: by nf-out-0910.google.com with SMTP id b11so924734nfh.13 for ; Sun, 02 Nov 2008 14:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=S/nfyoyCKi3da3gMuQPUMnjt2APUJmgjxH8aHTwiNBc=; b=eJccGkTPsqL4uDAtmDGVD++wOuF7ktJUeSwDCMrXIpSo04EoHZfn7uycfONLXljHUJ yrBv0rmJ5ginvGUxFFULtnSapfjrtb+cFp4bicRqhD18cru6VFOFAfN313llwGvZqD// g7/gvvbm1ghG9B/gbpVpU1SrLZS8EYUIpils0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=mVPmzziSGRp8A3uYBY0uD/8ux7V2396r0DP0MxTFVqsBJzhurn/vYVc8Z1MrUjiznB HrEbwxk5dwv/m8wDqwK2z1q6ghTZ/iv+kCO/tN8dB/4RoQgB//LDMsMw/2So5WnjQnDB TtZJYqP5ljMdDqCDvlvdRtEDeZky8eTM+BmPc= Received: by 10.210.42.20 with SMTP id p20mr16853516ebp.4.1225665707459; Sun, 02 Nov 2008 14:41:47 -0800 (PST) Received: by 10.210.79.1 with HTTP; Sun, 2 Nov 2008 14:41:47 -0800 (PST) Message-ID: <46ccd1ab0811021441w261ae033o9e2056f41b5738bb@mail.gmail.com> Date: Sun, 2 Nov 2008 20:41:47 -0200 To: "Lukas Kahwe Smith" Cc: "Ilia Alshanetsky" , "Hannes Magnusson" , "Steve Hanselman" , internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <11720FFB22BED511A66800E07D923B37011B34EC@prodntsc2.brendata> <7f3ed2c30810201346y574c317eub351fc46786ae92d@mail.gmail.com> <2B7F1826-332E-4E5D-813F-F453473B11B5@prohost.org> Subject: Re: [PHP-DEV] str_getcsv From: felipensp@gmail.com ("Felipe Pena") Hello, 2008/10/20 Lukas Kahwe Smith : > > On 20.10.2008, at 23:07, Ilia Alshanetsky wrote: > >> >> On 20-Oct-08, at 4:46 PM, Hannes Magnusson wrote: >> >>> On Mon, Oct 20, 2008 at 22:43, Steve Hanselman >>> wrote: >>>> >>>> Can anybody suggest a reason why this has never moved from main to >>>> php_5_2 or php_5_3? >>> >>> I did wonder the same months ago, but noone seemed to care, and I had >>> no use for it myself so I never bothered merging it :) >> >> The functionality is rather handy (I think), I would +1 for its addition >> to the 5.3 branch. > > > if someone commits it before alpha3 its fine by me. > Done! I've added a test and it's failing in HEAD though. We need check it, and to see what's the real behavior expected. A notable difference between the HEAD and 5.x fgetcsv implementation, is that in HEAD the delimiter, enclosure and escape can have more than 1 char. Then the following is valid: // string input[, string delimiter[, string enclosure[, string escape]]] var_dump(str_getcsv('<>foo++<><>[]<>bar<>', '[]', '<>', '++')); Should we really accept that? -- Regards, Felipe Pena.