Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41555 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81639 invoked from network); 29 Oct 2008 13:17:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Oct 2008 13:17:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.217.13 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.217.13 mail-gx0-f13.google.com Received: from [209.85.217.13] ([209.85.217.13:60736] helo=mail-gx0-f13.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/49-48169-F5268094 for ; Wed, 29 Oct 2008 08:17:20 -0500 Received: by gxk6 with SMTP id 6so633949gxk.23 for ; Wed, 29 Oct 2008 06:17:16 -0700 (PDT) Received: by 10.65.233.16 with SMTP id k16mr9289516qbr.45.1225286236139; Wed, 29 Oct 2008 06:17:16 -0700 (PDT) Received: from ?192.168.1.139? (TOROON63-1279386825.sdsl.bell.ca [76.65.228.201]) by mx.google.com with ESMTPS id k7sm5193033qba.3.2008.10.29.06.17.14 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 29 Oct 2008 06:17:15 -0700 (PDT) Cc: PHP internals Message-ID: To: Jani Taskinen In-Reply-To: <49085D70.3030400@sci.fi> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Date: Wed, 29 Oct 2008 09:17:13 -0400 References: <7A1407E0-56A2-4C8A-A964-86616311B928@prohost.org> <49085D70.3030400@sci.fi> X-Mailer: Apple Mail (2.929.2) Subject: Re: [PHP-DEV] PHP 5.2.7RC3 Reminder From: ilia@prohost.org (Ilia Alshanetsky) The problem here is that the domain parameter will eventually make its way into the file path and result in an overflow of the MAX_PATHLEN there (I suspect). The problem however (IMHO) lies in gettext that does not check the file path length before using it. For us to do the check will require an arbitrary limit, since the domain comprises only of a portion of the path and just putting a limit on its length of MAX_PATHLEN would not be enough. On 29-Oct-08, at 8:56 AM, Jani Taskinen wrote: > Ilia Alshanetsky wrote: >> Just a quick reminder for all of the developers, RC3 (the final RC) >> will be tagged tomorrow afternoon (EST) time, please try to get >> whatever patches (bug fixes only, please) you still want into it. >> If there are reasons to delay, critical patches missing, please let >> me know. > > http://bugs.php.net/bug.php?id=44938&edit=1 > > Marked critical but propably isn't. Also depatable whether it's a > PHP bug at all.. > > --Jani > Ilia Alshanetsky