Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41461
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain smashlabs.com from 67.15.58.61 cause and error)
Message-ID: <4905DB0E.4030703@smashlabs.com>
Date: Mon, 27 Oct 2008 10:15:26 -0500
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666
MIME-Version: 1.0
To: Hannes Magnusson <hannes.magnusson@gmail.com>
CC: Lukas Kahwe Smith <mls@pooteeweet.org>, =?ISO-8859-1?Q?Johannes_Sch?=
 =?ISO-8859-1?Q?l=FCter?= <johannes@php.net>, 
 Michael Wallner <mike@php.net>,
 internals@lists.php.net
References: <19.DC.27717.E51E7D84@pb1.pair.com>	 <1222171368.4213.7.camel@lstrojny>	 <413496B5-0EB4-45B5-BF05-D8B2E3951001@pooteeweet.org> <7f3ed2c30810270437s41c3cecerec1ee6a3cc5fb274@mail.gmail.com>
In-Reply-To: <7f3ed2c30810270437s41c3cecerec1ee6a3cc5fb274@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Adding pecl/http to core
From: ralph@smashlabs.com (Ralph Schindler)

While overall solid, I have 1 api critique that may or may not influence 
inclusion..

The naming's seem slightly awkward for HttpResponse.  Seemingly, 
HttpResponse is the compliment to HttpRequest given their namings.  But 
looking at the api (the fact that its all static methods), it leads me 
to believe that this class is more closely tied to the CURRENT PHP 
response buffer.  Is this the case?

While looking at the API for HttpRequest, it appears that after a 
request is sent, it retrives an HTTPMessage object back (which would 
make that class the compliment in the Request/Response paradigm).

If so, perhaps an alternate API and naming could be suggested? 
HttpCurrentResponse makes alot of sense to me (as to not imply itself as 
HttpRequest's compliment).. Also, would it make any sense (in this 
case), to change the API to non-static methods, and object instantiation 
to a getInstance() singleton pattern?  This would allow for the class to 
be extended and decorated and would be given more of an "object" feel- 
which i feel like this the real value added here.

Please correct me if I am wrong,

Thanks,
Ralph

Hannes Magnusson wrote:
> On Tue, Sep 23, 2008 at 13:54, Lukas Kahwe Smith <mls@pooteeweet.org> wrote:
>> I have not talked to Johannes about this, but unless there is a major major
>> major outcry from the internals folks to add it, its too late for 5.3.
> 
> I count one "vote" against it...
> 
> -Hannes
>