Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41367
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 192.18.6.21 as permitted sender)
Date: Fri, 24 Oct 2008 15:28:08 +0200
In-reply-to: <cd5680a20810240215t4d564ab6n4a397ff22166fa83@mail.gmail.com>
Sender: Johannes.Schlueter@Sun.COM
To: Alexey Zakhlestin <indeyets@gmail.com>
Cc: Ionut Gabriel Stan <ionut.g.stan@gmail.com>,
        Mark van der Velden <mark@dynom.nl>,
        Stanislav Malyshev <stas@zend.com>,
        PHP Internals <internals@lists.php.net>
Message-ID: <1224854888.19390.89.camel@goldfinger.johannes.nop>
MIME-version: 1.0
Content-type: text/plain
Content-transfer-encoding: 7BIT
References: <4900DB81.4000805@zend.com> <4900E150.1010607@dynom.nl>
 <49018FC3.90302@gmail.com>
 <cd5680a20810240215t4d564ab6n4a397ff22166fa83@mail.gmail.com>
Subject: Re: [PHP-DEV] array_key_exists BC break
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Fri, 2008-10-24 at 13:15 +0400, Alexey Zakhlestin wrote:
> On Fri, Oct 24, 2008 at 1:05 PM, Ionut Gabriel Stan
> <ionut.g.stan@gmail.com> wrote:
> > But wouldn't be useful to at least accept objects implementing ArrayAccess?
> 
> sounds like a good idea to me

nope that would mean that some scripts might work different between 5.2
and 5.3, now one gets an error. consider such a script:

<?php
class Foo extends ArrayAccess {
    public $prop = 42;
    function offsetGet($n) { ... }
    ....
}

$o = new foo;
array_key_Exists('prop', $o);
?>

In <= 5.2 it will return the value of $o->prop, in 5.3 it would call the
offsetGet() method. 

I prefer an error, if many people want the old behavior that's fine to
me, but don't change it.

btw. this also affects quite a few other functions: next/current/key/...
at least ... and maybe more after using the "new" parameter parsing API.

johannes