Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:41321 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78084 invoked from network); 22 Oct 2008 17:36:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Oct 2008 17:36:23 -0000 Authentication-Results: pb1.pair.com header.from=lstrojny@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lstrojny@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 78.46.69.2 as permitted sender) X-PHP-List-Original-Sender: lstrojny@php.net X-Host-Fingerprint: 78.46.69.2 milch.schokokeks.org Received: from [78.46.69.2] ([78.46.69.2:53540] helo=milch.schokokeks.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EC/E6-41302-2946FF84 for ; Wed, 22 Oct 2008 13:36:22 -0400 Received: from [10.88.8.133] (colt-d53d2146.colt.mediaventures.de [::ffff:213.61.33.70]) (AUTH: PLAIN lars@schokokeks.org, TLS: TLSv1/SSLv3,256bits,CAMELLIA256-SHA) by milch.schokokeks.org with esmtp; Wed, 22 Oct 2008 19:36:15 +0200 id 000000000000C007.0000000048FF648F.00005CA6 To: John Mertic Cc: internals@lists.php.net In-Reply-To: <2a9adcf0810221003i70f37558ob5777b5603865cdf@mail.gmail.com> References: <2a9adcf0810221003i70f37558ob5777b5603865cdf@mail.gmail.com> Date: Wed, 22 Oct 2008 19:36:14 +0200 Message-ID: <1224696974.17075.1.camel@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=_milch.schokokeks.org-23718-1224696975-0001-2" X-Mailer: Evolution 2.22.3.1 Subject: Re: [PHP-DEV] [PATCH] Bug #46367 - fputcsv does not add the correct newline character on Windows From: lstrojny@php.net (Lars Strojny) --=_milch.schokokeks.org-23718-1224696975-0001-2 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi John, Am Mittwoch, den 22.10.2008, 10:03 -0700 schrieb John Mertic: [...] > Below is a patch to fix this issue; it uses the constant PHP_EOL to > get the correct newline to use on the current platform: Thanks for your patch. A few things to mention, as it is your first patch: please use "diff -ru" to create unified diffs. Also we try to always add tests for the things we fix or create. Would you mind creating a test for the fix you sent to make sure no regression happens in the next n years? Thanks, Lars --=20 Jabber: lars@strojny.net Weblog: http://usrportage.de --=_milch.schokokeks.org-23718-1224696975-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Description: Dies ist ein digital signierter Nachrichtenteil -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) iQIbBAABAgAGBQJI/2SOAAoJECQPF+sCY6wHmeMP+NdTr5HdLad6hRQVrb5K35Qc 4qLD4TYt1PCvJ1h8EzqIFEp7nOgitxemr+8S+SRek9BcCpwMqRsi/EZ+wG5mx4WP bYJ/ATshaMJC1ViMdQZRTNqmCilQad2IPrG687ClhnGRkRhzbAE5+4/7kCwhX4GD LbtaoHM0Ohnb4/4NLxgG3xhnHG+iCjMhWjgNMCZVkdEQU9RNTw1dXOwxk03T3p3D enbmIxM8LX1duq2oyDyW0ygn42DKifMPUt7rGlo7y/WMKcvVRfKFexZyQ8N5D1dK Zk0TVorCDgcgusQUvtUA7A9hogEqkUOMViacU83ep2i5SC2Zl+/N5ULtfLXOcYaB L0K/8ruD9e5QOAU12SfvSWAnQqJIBhKPLe9sK5NreiT+J9i81xb4u6UojFZB4RQo Lsh+VhQOtuE1CGFq6Zr5VB2MN5KmRtbPoy4H6m36Tc70Aymyk6kbnZh5kdTrdIBO Uwj4yJ/8DwLMlZQUDgOqCYnxFEdmu8jGgh5xcn7azT1RudhDQAU8sLQ86r25TdDH aTEMZyn09t9DWPjgBrjNrktPMfi42yFWZ00znqonaLk4bxTmwCIJYhn2e11jrJWe bPAIttQjim4DU46FkUYE8gwl6YtatK+rortUCr17ZsFpWCIBBQQ+DhYhf0qC++pq oLZ9jOWej39Irph1Ibk= =5Uhe -----END PGP SIGNATURE----- --=_milch.schokokeks.org-23718-1224696975-0001-2--