Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41320
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.169 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:mime-version:content-type
         :content-transfer-encoding:content-disposition:x-google-sender-auth;
        b=br8hUfn5yo1TCCsF90pTn4kHw7c63N1IH/Jk8RAMVdRSM1XD2uhz4uyI+tBJU0vu6A
         YX2E5xDoF9AQ8pQ9J82MyfMe//SjA/iayRTZSBxnjDZkh8a74johC6JFp/QyAruaQdrS
         FM8ntrYJJy9Zx5vrHcBMevGzmx5PrxeRqW/pk=
Message-ID: <2a9adcf0810221003i70f37558ob5777b5603865cdf@mail.gmail.com>
Date: Wed, 22 Oct 2008 10:03:46 -0700
Sender: jmertic@gmail.com
To: internals@lists.php.net
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: [PATCH] Bug #46367 - fputcsv does not add the correct newline character on Windows
From: jmertic@php.net ("John Mertic")

Hi All,

My first patch so be gentle :-).

Per the documentation for the fputcsv() function, it adds a newline to
the end of the csv string it returns. However, it is hardcoded to be
'\n' ( default for unix newline ), while Windows uses \r\n. PHP should
do this as well.

Below is a patch to fix this issue; it uses the constant PHP_EOL to get
the correct newline to use on the current platform:

Index: php-src/ext/standard/file.c
===================================================================
RCS file: /repository/php-src/ext/standard/file.c,v
retrieving revision 1.530
diff -r1.530 file.c
2107c2107
< 	smart_str_appendc(&csvline, '\n');
---
> 	smart_str_appendc(&csvline, PHP_EOL);


John Mertic
jmertic@gmail.com
http://jmertic.wordpress.com

"Explaining a joke is like dissecting a frog: you understand it
better, but the frog dies
in the process." --Mark Twain