Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41318
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 83.243.58.133 cause and error)
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Christian Schmidt <chsc@peytz.dk>, internals@lists.php.net
In-Reply-To: <7f3ed2c30810200012pbdb0530u4561cb1848dab89f@mail.gmail.com>
References: <48FBA987.5030809@peytz.dk>
	 <7f3ed2c30810200012pbdb0530u4561cb1848dab89f@mail.gmail.com>
Content-Type: text/plain
Date: Wed, 22 Oct 2008 13:40:40 +0200
Message-ID: <1224675641.19390.61.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set using
	header()
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Mon, 2008-10-20 at 09:12 +0200, Hannes Magnusson wrote:
> > I suggest extending the behaviour of header() so that when the first
> > argument does not contain a colon (and does not begin with "HTTP/"), e.g.
> > header('Vary'), it unsets the header with the specified name. I decided to
> > extend the existing header() function rather than adding a new function,
> > because the existing function already supports multiple actions (add, append
> > and replace).
> 
> 
> That isn't very intuitive. I would think it was a typo when reading
> such code and fix the header line...
> I'd suggest explicit header_remove("Vary");

Agreed, a specific function with a clear name sounds better.

Christian, can you update the patch? - thanks!

johannes