Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:41104
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.157 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=pV83oOhOrkkkeMQY0bbSGzfWewi7SOactovaNbuJUKyYUdfxxlCx41J1iKUH4O4rrt
         nxgRb880JHTsG0M8CsCc5NIhYoJRgsQ/ERwdevG/vSZM3Ic2xaCwUdS2kTKwFzAaO5yY
         +u0obeX/y8BEoEYT63SpFmFE88WE96L/vZsus=
Message-ID: <2dedb8a0810151620p2bb0e5cerdcca52d5e6faf622@mail.gmail.com>
Date: Thu, 16 Oct 2008 01:20:34 +0200
To: "Lukas Kahwe Smith" <mls@pooteeweet.org>
Cc: "Markus Fischer" <markus@fischer.name>, 
	"PHP Development" <internals@lists.php.net>
In-Reply-To: <6FDD6D0C-CD70-4D52-9AFC-89A76A7D1E19@pooteeweet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <2dedb8a0810131904x523ffceau26c9ab299baf66fa@mail.gmail.com>
	 <941E2BA9-750D-4ADD-B633-6C63B92A1C6C@pooteeweet.org>
	 <48F498BD.9010704@fischer.name>
	 <6FDD6D0C-CD70-4D52-9AFC-89A76A7D1E19@pooteeweet.org>
Subject: Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
From: kalle.php@gmail.com ("Kalle Sommer Nielsen")

Hi

2008/10/14 Lukas Kahwe Smith <mls@pooteeweet.org>:
>
> On 14.10.2008, at 15:03, Markus Fischer wrote:
>
>> Hi,
>>
>> Lukas Kahwe Smith wrote:
>>>
>>> That being said I never used this function or the constants in my code.
>>> So is there anyone that does actually use it and has some objection?
>>
>> Me neither, but in such cases it's probably a good idea to take a look at
>> code search machines, e.g.
>>
>>
>> http://www.google.com/codesearch?as_q=define_syslog_variables&btnG=Search+Code&hl=en&as_lang=php&as_license_restrict=i&as_license=&as_package=&as_filename=&as_case=
>>
>
> right .. and the interesting thing there is that most of the code is using
> the constants even though it calls the function to define the variables
> beforehand. the faulty documentation is probably the cause of this. so for
> the most part people will just need to remove the function call.

I've removed it from HEAD and added an E_DEPRECATED notice on
define_syslog_variables() in 5.3. If you're having
define_syslog_variables=On in HEAD, it will result in an E_WARNING
just like safe_mode, magic_quotes ect.

Docs/wiki are updated aswell.

>
> regards,
> Lukas Kahwe Smith
> mls@pooteeweet.org
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

regrads

-- 
Kalle Sommer Nielsen