Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40976
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain cisco.com designates 144.254.224.140 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 14 Oct 2008 14:08:58 +0200
Message-ID: <BADE85FDE9053E4AAEC411E40C77C291A85A49@xmb-ams-33e.emea.cisco.com>
In-Reply-To: <941E2BA9-750D-4ADD-B633-6C63B92A1C6C@pooteeweet.org>
Thread-Topic: [PHP-DEV] Deprecate define_syslog_variables in 5.3
Thread-Index: Ackt0ImkVGGo5OfDS8GNQdOKyYkC8gAJLajA
References: <2dedb8a0810131904x523ffceau26c9ab299baf66fa@mail.gmail.com> <941E2BA9-750D-4ADD-B633-6C63B92A1C6C@pooteeweet.org>
To: <internals@lists.php.net>
Subject: RE: [PHP-DEV] Deprecate define_syslog_variables in 5.3
From: johncart@cisco.com ("John Carter -X (johncart - PolicyApp Ltd at Cisco)")

We use syslog a lot. I've always found define_syslog_variables to be
pointless and frankly a little bizarre.

+1 on this.

John.

-----Original Message-----
From: Lukas Kahwe Smith [mailto:mls@pooteeweet.org]=20
Sent: 14 October 2008 08:42
To: Kalle Sommer Nielsen
Cc: PHP Development
Subject: Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3


On 14.10.2008, at 04:04, Kalle Sommer Nielsen wrote:

> Hello internals
>
> I've been looking at the function define_syslog_variables(), and I'm=20
> unsure if its intentional to keep this old functionality in PHP,=20
> seeing as define_syslog_variables defines a shortcut for each of the
> LOG_* constants in the form of $LOG_*.
>
> Therefore I propose the function is being deprecated in 5.3 and=20
> removed in HEAD.


I agree. Fixing your code is easy (just remove the call to =20
define_syslog_variables() and the $ in front of LOG), maintains BC =20
with older PHP releases.

On the up side this function could create an insanely hard to debug =20
problem for users, is redundant and was a very bad idea from the start =20
(and the docs seem incorrect too).

That being said I never used this function or the constants in my =20
code. So is there anyone that does actually use it and has some =20
objection?

regards,
Lukas Kahwe Smith
mls@pooteeweet.org




--=20
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php