Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40969
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Cc: "PHP Development" <internals@lists.php.net>
Message-ID: <941E2BA9-750D-4ADD-B633-6C63B92A1C6C@pooteeweet.org>
To: Kalle Sommer Nielsen <kalle.php@gmail.com>
In-Reply-To: <2dedb8a0810131904x523ffceau26c9ab299baf66fa@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Date: Tue, 14 Oct 2008 09:41:59 +0200
References: <2dedb8a0810131904x523ffceau26c9ab299baf66fa@mail.gmail.com>
Subject: Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 14.10.2008, at 04:04, Kalle Sommer Nielsen wrote:

> Hello internals
>
> I've been looking at the function define_syslog_variables(), and I'm
> unsure if its intentional to keep this old functionality in PHP,
> seeing as define_syslog_variables defines a shortcut for each of the
> LOG_* constants in the form of $LOG_*.
>
> Therefore I propose the function is being deprecated in 5.3 and  
> removed in HEAD.


I agree. Fixing your code is easy (just remove the call to  
define_syslog_variables() and the $ in front of LOG), maintains BC  
with older PHP releases.

On the up side this function could create an insanely hard to debug  
problem for users, is redundant and was a very bad idea from the start  
(and the docs seem incorrect too).

That being said I never used this function or the constants in my  
code. So is there anyone that does actually use it and has some  
objection?

regards,
Lukas Kahwe Smith
mls@pooteeweet.org