Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40874
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 192.18.6.21 as permitted sender)
Date: Tue, 07 Oct 2008 14:21:20 +0200
In-reply-to: <DF.F8.48736.5513AE84@pb1.pair.com>
Sender: Johannes.Schlueter@Sun.COM
To: Tim Steiner <tsteiner@nerdclub.net>
Cc: internals@lists.php.net
Message-ID: <1223382080.4412.17.camel@goldfinger.johannes.nop>
MIME-version: 1.0
Content-type: text/plain
Content-transfer-encoding: 7BIT
References: <DF.F8.48736.5513AE84@pb1.pair.com>
Subject: Re: [PHP-DEV] [PATCH] Bug #44251
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Mon, 2008-10-06 at 10:40 -0500, Tim Steiner wrote:
> Greetings,
> 
> I have created a patch for Bug #44251 (Question mark and an escaped 
> singel quote lead to an exception).

Thanks, the test passed my initial tests, I'll commit it later today to
the branches.

> This is my first patch submission, so I have some questions:
> The patch is against 5.2.6.  Should it be against a different version?

In general: It would be perfect to provide a patch for all active
branches (HEAD/6.0, 5.3 and, as this is a bugfix, 5.2) against CVS. In
this case PDO doesn't differ too much between the branches so your patch
works directly so no work needed.

> I had to alter a .re file and a regenerated the .c file with re2c 
> 0.13.5.  Should I use a different version and if so where can I get it? 
>   Should I even be submitting the updated .c file?

re2c can be found at http://re2c.org 0.13.5 is the latest version and is
fine. And yes, providing the generated files in a patch helps people
testing (while everybody working in that area should have re2c
available)

> Thanks!

Thank you!

johannes