Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40815 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74635 invoked from network); 1 Oct 2008 07:53:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Oct 2008 07:53:02 -0000 Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 88.198.8.16 bigtime.backendmedia.com Linux 2.6 Received: from [88.198.8.16] ([88.198.8.16:44240] helo=bigtime.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CC/B9-12248-B5C23E84 for ; Wed, 01 Oct 2008 03:53:00 -0400 Received: from localhost (unknown [127.0.0.1]) by bigtime.backendmedia.com (Postfix) with ESMTP id CD8811EBC01C; Wed, 1 Oct 2008 07:53:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from bigtime.backendmedia.com ([127.0.0.1]) by localhost (bigtime.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JTINFc-QLFeK; Wed, 1 Oct 2008 09:53:09 +0200 (CEST) Received: from [192.168.80.161] (unknown [195.226.16.50]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by bigtime.backendmedia.com (Postfix) with ESMTP id 71B331EBC014; Wed, 1 Oct 2008 09:53:09 +0200 (CEST) To: Timm Friebe In-Reply-To: X-Priority: 3 References: <01d401c8fe5e$6bc9d730$16b2a8c0@kartofel> <022101c8fe5f$4a3e3c40$16b2a8c0@kartofel> <1901158190.20080815120657@marcus-boerger.de> <7EB12BC1-41F1-458C-8017-9AB4D910CAA5@pooteeweet.org> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Date: Wed, 1 Oct 2008 09:52:36 +0200 Cc: "Marcus Boerger" , , =?ISO-8859-1?Q?Johannes_Schl=FCter?= X-Mailer: Apple Mail (2.929.2) Subject: Re: [PHP-DEV] __getStatic From: mls@pooteeweet.org (Lukas Kahwe Smith) On 08.09.2008, at 11:23, Timm Friebe wrote: > Hi, > > [...__(set|get|unset|isset)static()...] >>> Patch looks pretty good. Plaease add __issetStatic and >>> __unsetStatic. Then provide tests and submit to HEAD. For 5.3 >>> Lukas and Johannes have to agree but I am sure they first want to >>> see it in HEAD. >> >> Hope we havent missed any other we need to make this stuff >> complete .. >> But here is the blessing of the two RM's to have this committed >> before the alpha2 release .. > > I've updated the patch and added some tests with it. > > http://sitten-polizei.de/php/getstatic.diff > > This requires a zend_vm_gen.php as I needed a new opcode > (ZEND_ASSIGN_CLASS, 137). Please review this patch carefully, > especially the part in zend_vm_def.h, I'm not sure this is correct. Can someone review this patch? regards, Lukas Kahwe Smith mls@pooteeweet.org