Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40782 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55173 invoked from network); 29 Sep 2008 16:15:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Sep 2008 16:15:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=david.zuelke@bitextender.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=david.zuelke@bitextender.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain bitextender.com from 80.237.132.12 cause and error) X-PHP-List-Original-Sender: david.zuelke@bitextender.com X-Host-Fingerprint: 80.237.132.12 wp005.webpack.hosteurope.de Received: from [80.237.132.12] ([80.237.132.12:41487] helo=wp005.webpack.hosteurope.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8A/78-36431-D0FF0E84 for ; Mon, 29 Sep 2008 12:15:11 -0400 Received: from munich.bitxtender.net ([85.183.90.3] helo=[10.224.254.2]); authenticated by wp005.webpack.hosteurope.de running ExIM using esmtpsa (TLSv1:RC4-SHA:128) id 1KkLOs-0004AW-5N; Mon, 29 Sep 2008 18:15:06 +0200 Cc: "Brian J. France" , internals@lists.php.net Message-ID: To: Dmitry Stogov In-Reply-To: <48E08DBC.7060000@zend.com> Content-Type: multipart/signed; boundary=Apple-Mail-10--415430181; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v929.2) Date: Mon, 29 Sep 2008 18:15:04 +0200 References: <1890A80D-FE2B-413C-9B41-C56FB17B865D@firehawksystems.com> <48E08DBC.7060000@zend.com> X-Mailer: Apple Mail (2.929.2) X-bounce-key: webpack.hosteurope.de;david.zuelke@bitextender.com;1222704911;c8c85fd2; Subject: Re: [PHP-DEV] ext/soap and http header From: david.zuelke@bitextender.com (=?ISO-8859-1?Q?David_Z=FClke?=) --Apple-Mail-10--415430181 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit just curious, why is ext/soap internally duplicating this http stuff instead of using the http stream stuff directly? or did I misunderstand something? Am 29.09.2008 um 10:11 schrieb Dmitry Stogov: > Hi Brian, > > I think you patch does the things you like properly, but why do we > need > such ability? I don't see a use-case. > > In case of accepting this patch, we also need to care about duplicate > headers. > > Thanks. Dmitry. > > Brian J. France wrote: >> After some more testing I needed to tweak the patch and the example, >> here is version 2. >> >> $opts = array('http' => array('header' => 'X-foo: bar')); >> $ctx = stream_context_create($opts); >> >> Brian >> >> >> --- ext/soap/php_http.c.orig 2008-09-26 05:39:50.000000000 -0700 >> +++ ext/soap/php_http.c 2008-09-26 06:42:34.000000000 -0700 >> -391,7 +391,8 @@ >> PG(allow_url_fopen) = old_allow_url_fopen; >> >> if (stream) { >> - zval **cookies, **login, **password; >> + php_stream_context *context = NULL; >> + zval **cookies, **login, **password, **tmpzval = NULL; >> int ret = zend_list_insert(phpurl, le_url); >> >> add_property_resource(this_ptr, "httpurl", ret); >> -638,6 +639,19 @@ >> proxy_authentication(this_ptr, &soap_headers TSRMLS_CC); >> } >> >> + /* get context to check for http headers */ >> + if (SUCCESS == zend_hash_find(Z_OBJPROP_P(this_ptr), >> + "_stream_context", >> sizeof("_stream_context"), >> (void**)&tmp)) { >> + context = php_stream_context_from_zval(*tmp, 0); >> + } >> + >> + /* Send http headers from context */ >> + if (context && >> + php_stream_context_get_option(context, "http", "header", >> &tmpzval) == SUCCESS && >> + Z_TYPE_PP(tmpzval) == IS_STRING && >> Z_STRLEN_PP(tmpzval)) { >> + smart_str_appendl(&soap_headers, Z_STRVAL_PP(tmpzval), >> Z_STRLEN_PP(tmpzval)); >> + } >> + >> /* Send cookies along with request */ >> if (zend_hash_find(Z_OBJPROP_P(this_ptr), "_cookies", >> sizeof("_cookies"), (void **)&cookies) == SUCCESS) { >> zval **data; > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --Apple-Mail-10--415430181 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGXDCCAxUw ggJ+oAMCAQICEHvgrI6DXM4XmK4XvhB7lh4wDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MDgyMjE0MjEzOVoXDTA5MDgyMjE0MjEz OVowTjEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjErMCkGCSqGSIb3DQEJARYcZGF2 aWQuenVlbGtlQGJpdGV4dGVuZGVyLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEB ANx+fe+8oUaO+fotZryRBmD3NAP00QikUIqIyZKiwJ4BS9M8DdqN0lAh443rdw1h/H0NVkDMv7+7 MnSUYKU+BTwulvU7WDGLm7JGkXXWkGl5vHUnUWltUkk8ImUDiunYPnuyUVyQlnZkp1ThihYoR4xo MmiiC+6mHLl8FzMKimOU/UREpGfyLqYhsNdXiVgm+W8feO6aY3fDaenn9EVZEXJs6t7KxLpCIlD2 8+0dHlX+91vV4a9zfMObjEkLW3w/uBTT+uHypySHo/EWw0/pOD34sMdhSh0Xyr4un+Uv/DHH1ft3 5TJq6DEIrIL4iUpGa7Nsqjoah5SgpWwJY+gWaC8CAwEAAaNcMFowDgYDVR0PAQH/BAQDAgSwMBEG CWCGSAGG+EIBAQQEAwIFIDAnBgNVHREEIDAegRxkYXZpZC56dWVsa2VAYml0ZXh0ZW5kZXIuY29t MAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEFBQADgYEAbEPiMjevqmbl2NuGieZkF5fNV1Uhr0dL wGDDxIcIHGnBeEBVy/5NpAKJUCU4lqG+bqD1S4MdyyLxvzlhOSZEqjcEwtwXqLVsaDakYFHsRGaS DU160+1b/wlf8/OR5tof7y5MA8p6MSQHjXWOy38A71wvwFowGZPF5lY617W5mUMwggM/MIICqKAD AgECAgENMA0GCSqGSIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBD YXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYD VQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVy c29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0 ZS5jb20wHhcNMDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMG A1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVz VftOucqZWh5owHUEcJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Va qj9xVsuvPAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20Txh BEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0 hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNV HQ8EBAMCAQYwKQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqG SIb3DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCT cDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo0 5RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTEl MCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBl cnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEHvgrI6DXM4XmK4XvhB7lh4wCQYFKw4DAhoFAKCC AW8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDgwOTI5MTYxNTA1 WjAjBgkqhkiG9w0BCQQxFgQUiyAH9RyBmU4/wBH46SZvksm2RWswgYUGCSsGAQQBgjcQBDF4MHYw YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhB74KyOg1zOF5iuF74Q e5YeMIGHBgsqhkiG9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBD b25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJ c3N1aW5nIENBAhB74KyOg1zOF5iuF74Qe5YeMA0GCSqGSIb3DQEBAQUABIIBAISRkfVPVWh5AbvK Xq09r45ftm/PkEijwoCE5iuBi0pznjeLVHmmOmD+vkcZWsVGD+0AFdrf2nk9euLCZIEKqMOzIpFO AQQnBETrpcKTo39UbngQ8XsJDNEsGDtTZIFqTkuxEvXHctaSq+mrgAkFJn2oRwI8fgP0u8e8gx8O PIEKFrFMA+qWQKiQJqz463Ksufc0i19E5NsQVi72K8Db5/P2y2+qz+qI0OxKmDF4pZ7NSnPofQsq haa5k8hKcaWZ/zo/OQ/sBLSYSmVDVrTrfZ/vPYaKJpkrDu0AatUGF7xIsL3Oa5QoyCd6ouICQ5I0 QnKb9fi9ccwVN/6oi2QjZBMAAAAAAAA= --Apple-Mail-10--415430181--