Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40730 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33366 invoked from network); 27 Sep 2008 08:11:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Sep 2008 08:11:23 -0000 Authentication-Results: pb1.pair.com header.from=ilia.cheishvili@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=ilia.cheishvili@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.162.178 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: ilia.cheishvili@gmail.com X-Host-Fingerprint: 209.85.162.178 el-out-1112.google.com Received: from [209.85.162.178] ([209.85.162.178:47184] helo=el-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B7/50-30545-AAAEDD84 for ; Sat, 27 Sep 2008 04:11:22 -0400 Received: by el-out-1112.google.com with SMTP id o28so351627ele.2 for ; Sat, 27 Sep 2008 01:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=YZYZPjmM5o+pVVe9InBeVW8NfVmmYpweeZJLbCinD6E=; b=kYUZYwBYH/w3xAVLmRNBtobzEVO2GT9aQmpmw3TPP/ezW707SEla6QMwFB6wQFs9uc nimedRgYkAnwD+NQUhtbbygjicXZGpzJnPCtkdbGsFQzw/Ac7b9960YzdhBU6Prq4AUl H4KD2dfi+/N5pGS5tb2YgwEhiI6nDK6dQw7QI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=UzXd+N0I5ef6EAr1wlLMg725ux5BMnIw4Gxv5Jax5vBgHjFSwU/+SyqRSbfCQPe145 HjnvMRZeQ/WW6iXwxs5gObGgro7bzDu1B8M40U5hA61vJGB6r0FJmxWU0955UItcPul2 BobukC0Q2RQXnhXKlQm9CJ+Xxw0EUF6yl4HhI= Received: by 10.151.113.11 with SMTP id q11mr3496861ybm.249.1222502643321; Sat, 27 Sep 2008 01:04:03 -0700 (PDT) Received: by 10.151.144.11 with HTTP; Sat, 27 Sep 2008 01:04:03 -0700 (PDT) Message-ID: Date: Sat, 27 Sep 2008 02:04:03 -0600 To: "Alexey Zakhlestin" Cc: "PHP internals" In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_18564_23598129.1222502643287" References: Subject: Re: [PHP-DEV] [PATCH] Fix date() bug From: ilia.cheishvili@gmail.com ("Ilia Cheishvili") ------=_Part_18564_23598129.1222502643287 Content-Type: multipart/alternative; boundary="----=_Part_18565_16964705.1222502643287" ------=_Part_18565_16964705.1222502643287 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline It definitely would be, and that's actually the way I would have preferred to do it. I didn't want to impact too much code, if that makes sense in this case, but I'm glad that someone agrees :) I have attached a patch to do exactly this. Ilia On Sat, Sep 27, 2008 at 1:40 AM, Alexey Zakhlestin wrote: > On Sat, Sep 27, 2008 at 11:04 AM, Ilia Cheishvili > wrote: > > Hi all, > > This patch addresses the issue with the date() function. When passing in > a > > 'u', the date() function simply outputs six zeros. To fix this, I added > a > > gettimeofday() call that figures out what to display for microseconds. I > am > > including the headers and using the function with pre-processor > safeguards > > as well. > > Take a look :) > > Wouldn't it be better, to make gettimeofday() call only in case of 'u'? > > > -- > Alexey Zakhlestin > http://blog.milkfarmsoft.com/ > ------=_Part_18565_16964705.1222502643287 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
It definitely would be, and that's actually the way I would have preferred to do it.  I didn't want to impact too much code, if that makes sense in this case, but I'm glad that someone agrees :)

I have attached a patch to do exactly this.

Ilia

On Sat, Sep 27, 2008 at 1:40 AM, Alexey Zakhlestin <indeyets@gmail.com> wrote:
On Sat, Sep 27, 2008 at 11:04 AM, Ilia Cheishvili
<ilia.cheishvili@gmail.com> wrote:
> Hi all,
> This patch addresses the issue with the date() function.  When passing in a
> 'u', the date() function simply outputs six zeros.  To fix this, I added a
> gettimeofday() call that figures out what to display for microseconds.  I am
> including the headers and using the function with pre-processor safeguards
> as well.
> Take a look :)

Wouldn't it be better, to make gettimeofday() call only in case of 'u'?


--
Alexey Zakhlestin
http://blog.milkfarmsoft.com/

------=_Part_18565_16964705.1222502643287-- ------=_Part_18564_23598129.1222502643287 Content-Type: text/plain; name=date-u-fix-diff.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fllyh20c0 Content-Disposition: attachment; filename=date-u-fix-diff.txt SW5kZXg6IHBocF9kYXRlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3JlcG9zaXRvcnkvcGhwLXNy Yy9leHQvZGF0ZS9waHBfZGF0ZS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQzLjIuNDUuMi41 MS4yLjU0CmRpZmYgLXUgLWIgLXIxLjQzLjIuNDUuMi41MS4yLjU0IHBocF9kYXRlLmMKLS0tIHBo cF9kYXRlLmMJOCBBdWcgMjAwOCAyMjowNzowNyAtMDAwMAkxLjQzLjIuNDUuMi41MS4yLjU0Cisr KyBwaHBfZGF0ZS5jCTI3IFNlcCAyMDA4IDA4OjAyOjA2IC0wMDAwCkBAIC0zMCw2ICszMCwxNCBA QAogI2luY2x1ZGUgInplbmRfaW50ZXJmYWNlcy5oIgogI2luY2x1ZGUgImxpYi90aW1lbGliLmgi CiAjaW5jbHVkZSA8dGltZS5oPgorI2lmZGVmIFBIUF9XSU4zMgorI2luY2x1ZGUgIndpbjMyL3Rp bWUuaCIKKyNlbGlmIGRlZmluZWQoTkVUV0FSRSkKKyNpbmNsdWRlIDxzeXMvdGltZXZhbC5oPgor I2luY2x1ZGUgPHN5cy90aW1lLmg+CisjZWxzZQorI2luY2x1ZGUgPHN5cy90aW1lLmg+CisjZW5k aWYKIAogLyoge3t7IGFyZ2luZm8gKi8KIHN0YXRpYwpAQCAtMTA3NSw2ICsxMDgzLDggQEAKIAl0 aW1lbGliX3RpbWVfb2Zmc2V0ICpvZmZzZXQgPSBOVUxMOwogCXRpbWVsaWJfc2xsICAgICAgICAg IGlzb3dlZWssIGlzb3llYXI7CiAJaW50ICAgICAgICAgICAgICAgICAgcmZjX2NvbG9uOworCXN0 cnVjdCB0aW1ldmFsIHRwID0gezB9OworCXN0cnVjdCB0aW1lem9uZSB0eiA9IHswfTsKIAogCWlm ICghZm9ybWF0X2xlbikgewogCQlyZXR1cm4gZXN0cmR1cCgiIik7CkBAIC0xMTUwLDcgKzExNjAs OSBAQAogCQkJY2FzZSAnSCc6IGxlbmd0aCA9IHNscHJpbnRmKGJ1ZmZlciwgMzIsICIlMDJkIiwg KGludCkgdC0+aCk7IGJyZWFrOwogCQkJY2FzZSAnaSc6IGxlbmd0aCA9IHNscHJpbnRmKGJ1ZmZl ciwgMzIsICIlMDJkIiwgKGludCkgdC0+aSk7IGJyZWFrOwogCQkJY2FzZSAncyc6IGxlbmd0aCA9 IHNscHJpbnRmKGJ1ZmZlciwgMzIsICIlMDJkIiwgKGludCkgdC0+cyk7IGJyZWFrOwotCQkJY2Fz ZSAndSc6IGxlbmd0aCA9IHNscHJpbnRmKGJ1ZmZlciwgMzIsICIlMDZkIiwgKGludCkgZmxvb3Io dC0+ZiAqIDEwMDAwMDApKTsgYnJlYWs7CisjaWZkZWYgSEFWRV9HRVRUSU1FT0ZEQVkKKwkJCWNh c2UgJ3UnOiBnZXR0aW1lb2ZkYXkoJnRwLCAmdHopOyBsZW5ndGggPSBzbHByaW50ZihidWZmZXIs IDMyLCAiJTA2ZCIsIChpbnQpIHRwLnR2X3VzZWMpOyBicmVhazsKKyNlbmRpZgogCiAJCQkvKiB0 aW1lem9uZSAqLwogCQkJY2FzZSAnSSc6IGxlbmd0aCA9IHNscHJpbnRmKGJ1ZmZlciwgMzIsICIl ZCIsIGxvY2FsdGltZSA/IG9mZnNldC0+aXNfZHN0IDogMCk7IGJyZWFrOwo= ------=_Part_18564_23598129.1222502643287--