Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40716
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Cc: Michael Wallner <mike@php.net>,
 internals@lists.php.net
Message-ID: <6CD31FE7-FD3E-4656-BBFA-04D6F4789DFE@pooteeweet.org>
To: jani.taskinen@iki.fi
In-Reply-To: <48DD3FAE.8050807@sci.fi>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Date: Fri, 26 Sep 2008 22:05:44 +0200
References: <03.52.27158.9D5A2D84@pb1.pair.com> <DE46E177-EF36-4B75-AC14-5AFDA84A84DD@pooteeweet.org> <1D.C1.19781.C63BCD84@pb1.pair.com> <94232D93-D448-4403-A81D-2EB5904AAB8D@pooteeweet.org> <48DD3FAE.8050807@sci.fi>
Subject: Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 26.09.2008, at 22:01, Jani Taskinen wrote:

> Lukas Kahwe Smith wrote:
>> On 26.09.2008, at 12:04, Michael Wallner wrote:
>>> Lukas Kahwe Smith wrote:
>>>> well the question is does it fix some real world bugs? this late  
>>>> in the
>>>> game i would not want to include these changes if they "just" add
>>>> features ..
>>>
>>> Huh? :)  The question to me is, why did you ask me to do it, when
>>> you're not sure what it's about? Not to be anally at all... ;)
>> I guess we cleared up the misunderstanding on IRC.
>>> The greatest plus to me are:
>>>    - getting rid of monolithic php_end_ob_buffer()
>>>    - getting rid of output handler specific code in SAPI.c
>>>    - being able to hook from the running output handler to change  
>>> it's behavior
>>>    - being able to clearly configure conflicts and reverse  
>>> conflicts between output handlers
>> These are all convincing arguments to have done this earlier. But  
>> Johannes and I are a bit worried, that this code did not see that  
>> much testing since it was checked in to HEAD quite a while ago. And  
>> seeing that the backport is mainly cleanup and not bug fixing, we  
>> are a bit worried about the risk this backport has (not necessarily  
>> in it introducing bugs, but more about BC issues here and there).  
>> Especially since it seems that you are the only one who actively  
>> looks after output buffering .. (Johannes actually asked to have  
>> this stuff in PHP 5.3 months ago, but you were a  bit MIA back  
>> then .. and nobody else showed interest).
>> So unless you can take our worries away in terms of BC issues, I  
>> guess we would prefer to leave this patch out of PHP 5.3.
>> Sorry about the misunderstanding and the work you put into  
>> producing this patch.
>
> The patch fixes several output buffer bugs. Those alone are enough  
> to allow this getting in PHP_5_3 and really get TESTED too.

if it does fix bugs .. that changes things of course .. but i asked  
Mike specifically about this .. and he did not mention this .. so does  
it fix bugs or not?

regards,
Lukas Kahwe Smith
mls@pooteeweet.org